Failing on compilation due to `TS2403: Subsequent variable declarations must have the same type.`

[NickGlenn]

• Rollup Plugin Name: typescript
• Rollup Plugin Version: 3.0.0
• Rollup Version: 1.30.1, 1.27.14
• Operating System (or Browser): Windows, OSX
• Node Version: 8.10.0 (Win), 12.15.0 (Win), 12.15.0 (OSX)

How Do We Reproduce?

Repl.it Project Replicating the Issue

I've seen this occur on a couple different libraries know, but the most notable one is react-router-dom. Set up a React project and install react-router-dom along with the types, @types/react-router-dom.

Expected Behavior

Ideally it should compile unless there's actual user error. Using the exact same project but with the old rollup-plugin-typescript module works flawlessly.

Actual Behavior

Build fails due to TS2403: Subsequent variable declarations must have the same type. Variable 'History' ....

src/index.tsx → dist/bundle.js...
[!] (plugin typescript) Error: @rollup/plugin-typescript TS2403: Subsequent variable declarations must have the same type.  Variable 'History' must be of type 'typeof import("/home/runner/PeskyBigheartedForms/node_modules/@types/history/index")', but here has type '{ new (): import("/home/runner/PeskyBigheartedForms/node_modules/@types/history/index"); prototype: import("/home/runner/PeskyBigheartedForms/node_modules/@types/history/index"); }'.
node_modules/typescript/lib/lib.dom.d.ts (9211:13)

9211 declare var History: {
                 ~~~~~~~

  node_modules/@types/history/index.d.ts:6:1
    6 export as namespace History;
      ~~~~~~
    'History' was also declared here.

Error: @rollup/plugin-typescript TS2403: Subsequent variable declarations must have thesame type.  Variable 'History' must be of type 'typeof import("/home/runner/PeskyBigheartedForms/node_modules/@types/history/index")', but here has type '{ new (): import("/home/runner/PeskyBigheartedForms/node_modules/@types/history/index"); prototype: import("/home/runner/PeskyBigheartedForms/node_modules/@types/history/index"); }'.
    at error (/home/runner/PeskyBigheartedForms/node_modules/rollup/dist/rollup.js:5365:30)
    at throwPluginError (/home/runner/PeskyBigheartedForms/node_modules/rollup/dist/rollup.js:11725:12)
    at Object.error (/home/runner/PeskyBigheartedForms/node_modules/rollup/dist/rollup.js:12694:24)
    at diagnostics.filter.forEach (/home/runner/PeskyBigheartedForms/node_modules/@rollup/plugin-typescript/dist/index.js:27:21)
    at Array.forEach (<anonymous>)
    at emitDiagnostics (/home/runner/PeskyBigheartedForms/node_modules/@rollup/plugin-typescript/dist/index.js:22:10)
    at Object.generateBundle (/home/runner/PeskyBigheartedForms/node_modules/@rollup/plugin-typescript/dist/index.js:474:13)
    at Promise.resolve.then (/home/runner/PeskyBigheartedForms/node_modules/rollup/dist/rollup.js:12899:25)
    at process._tickCallback (internal/process/next_tick.js:68:7)

exit status 1

[NotWoods]

You can tell the plugin to compile anyways by setting noEmitOnError to false.

[NotWoods]

If you explicitly set lib, does the error go away?

[NickGlenn]

Hey @NotWoods ,

Sadly, noEmitOnError doesn't force a build in this case and explicitly setting lib doesn't solve the issue either. I'm guessing the cause is that react-router-dom brings in @types/history, which has a History interface that clashes with the "dom" library's History type. Did something change with how TS globals are handled since the previous version of this plugin?

[NotWoods]

Yes, the current version turns on typechecking as we previously did not do any checks beyond transpiling the file. If this compiles with Typescript normally the plugin should handle it, so I'll try to fix the bug.

[NickGlenn]

Awesome, thanks @NotWoods

[Paosder]

Is there any workaround or progress for this? I'm stuck in here.

[NickGlenn]

@Paosder Although not ideal, I've been using the original rollup-plugin-typescript module without issue. You may consider using that for the time being until this issue is resolved.

[NotWoods]

Agreed. The next plugin version will be published soon (and is already on master).

[NickGlenn]

@NotWoods This is exciting news, big thanks to you and the team for working on this!

[shellscape]

@NotWoods need me to cut a new release? (sorry, work has been murder lately)

[NotWoods]

@shellscape Please do 😄 I sent you a list of updated plugins on Discord

[shellscape]

Done

[NotWoods]

Fixed in version 4.0.0 of the typescript plugin