feat(commonjs): Restore support for Node 10 after #1038#1219
Closed
niklasf wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks for the PR, unfortunately our support policy is dictated by the Node LTS policy, which can be viewed here: https://nodejs.org/en/about/releases/ Rollup supporting v10+ is likely an oversight, since v10 dropped out of LTS a very long time ago. |
Member
|
We are actively preparing Rollup v3 now, that raises the bar to Node 14 anyway |
Author
|
Fair enough. Thanks for the quick response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
Description
#1038 raised the required Node version of the
commonjsplugin from 8 to 12, mentioning:Since
rollupitself is still usable with Node 10, it makes some sense to stick with 10 as long as reasonably convenient.