update package dependencies by shellscape · Pull Request #160 · rollup/plugins

shellscape · 2020-01-11T03:02:54Z

Rollup Plugin Name: many

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

List any relevant issue numbers:

Description

This is a repo-wide dependency update to get packages off of deprecated versions of plugins.

This PR should be straight merged and not squash merged.

Individual publishes for packages that match chore({name}): update dependencies will follow after the merge. pluginutils was left out as it won't build with the new version of commonjs due to a regression (which I opened another issue for)

shellscape · 2020-01-11T03:16:42Z

I've no idea why CI is failing on node-resolve tests. Locally the test, ci:test, and ci:coverage scripts succeed. Please pull the branch and run pnpm run ci:test from repo root to verify.

wuweiweiwu · 2020-01-11T03:56:13Z

LGTM! Ci:tests pass locally for me as well.

Kocal · 2020-01-13T09:28:30Z

pnpm ci:test fails for me:

packages/node-resolve ci:test$ pnpm run test -- --verbose && pnpm run test:ts
│ Scope: current workspace package
│ > @rollup/plugin-node-resolve@7.0.0 pretest /home/hugo/workspace-os/plugins/packages/node-resolve
│ > pnpm run build
│ Scope: current workspace package
│ > @rollup/plugin-node-resolve@7.0.0 prebuild /home/hugo/workspace-os/plugins/packages/node-resolve
│ > del-cli dist
│ > @rollup/plugin-node-resolve@7.0.0 build /home/hugo/workspace-os/plugins/packages/node-resolve
│ > rollup -c
│ src/index.js → dist/index.js, dist/index.es.js...
│ created dist/index.js, dist/index.es.js in 759ms
│ > @rollup/plugin-node-resolve@7.0.0 test /home/hugo/workspace-os/plugins/packages/node-resolve
│ > ava "--verbose"
│ node-resolve: setting options.module is deprecated, please override options.mainFields instead
│ node-resolve: setting options.jsnext is deprecated, please override options.mainFields instead
│ node-resolve: setting options.main is deprecated, please override options.mainFields instead
│   ✔ jail › mark module outside the jail as external
│   ✔ jail › bundle module defined inside the jail
│ node-resolve: setting options.jsnext is deprecated, please override options.mainFields instead
│ node-resolve: setting options.main is deprecated, please override options.mainFields instead
│ node-resolve: setting options.module is deprecated, please override options.mainFields instead
│ node-resolve: setting options.main is deprecated, please override options.mainFields instead
│ node-resolve: setting options.module is deprecated, please override options.mainFields instead
│ node-resolve: setting options.jsnext is deprecated, please override options.mainFields instead
│ node-resolve: setting options.main is deprecated, please override options.mainFields instead
│ node-resolve: setting options.module is deprecated, please override options.mainFields instead
│ node-resolve: setting options.main is deprecated, please override options.mainFields instead
│   ✔ order › respects order if given module,jsnext:main,main (111ms)
│   ✔ order › respects order if given jsnext:main, main (103ms)
│   ✔ order › keeps the order of [browser, module, jsnext, main] with all enabled (110ms)
│   ✔ order › finds and uses a dual-distributed .js & .mjs module (115ms)
│   ✔ dedupe-custom › can deduplicate custom module directory (107ms)
│   ✔ prefer-builtins › true allows preferring a builtin to a local module of the same name
│   ✔ prefer-builtins › warning when preferring a builtin module, no explicit configuration
│   ✔ deprecated › should support enabling "jsnext" field resolution
│   ✔ prefer-builtins › false allows resolving a local module with the same name as a builtin module
│   ✔ deprecated › should support disabling "main" field resolution
│   ✔ deprecated › should support disabling "module" field resolution
│   ✔ deprecated › options.jsnext still works with correct priority
│   ✔ deprecated › finds a module with module field
│   ✔ prefer-builtins › warns when importing builtins
│   ✔ deprecated › options.module still works with correct priority
│   ✔ get-package-info › populates info for browser (110ms)
│   ✔ test › ignores IDs with null character
│   ✔ get-package-info › populates info for module (117ms)
│   ✔ get-package-info › populates info for main (127ms)
│ node-resolve: setting options.main is deprecated, please override options.mainFields instead
│   ✔ dedupe › dedupes deep imports by package name if dedupe is set (119ms)
│   ✔ dedupe › single module version is bundled if dedupe is set (129ms)
│   ✔ dedupe › single module version is bundled if dedupe is set as a function (124ms)
│   ✔ dedupe › dedupes scoped deep imports by package name if dedupe is set (126ms)
│   ✔ dedupe › multiple module versions are bundled if dedupe is not set (128ms)
│   ✔ only › specify the only packages to resolve (102ms)
│   ✔ only › regex
│   ✔ symlinks › resolves symlinked packages
│   ✔ symlinks › preserves symlinks if `preserveSymlinks` is true
│   ✔ root-dir › deduplicates modules from the given root directory
│   ✔ browser › disregards top-level browser field
│   ✔ browser › allows use of the top-level browser field
│   ✔ browser › respects local browser field
│   ✔ browser › allows use of object browser field, resolving implicit `main`
│   ✔ browser › supports `false` in browser field
│   ✔ browser › allows use of object browser field, resolving `main` (110ms)
│   ✔ browser › allows use of object browser field, resolving replaced builtins (110ms)
│   ✔ browser › options.browser = true still works (113ms)
│   ✔ browser › allows use of the object browser field (114ms)
│   ✔ browser › allows use of object browser field, resolving nested directories (114ms)
│   ✔ browser › disregards object browser field (122ms)
│   ✔ browser › allows use of object browser field, resolving to nested node_modules (121ms)
│   ✔ browser › pkg.browser with mapping to prevent bundle by specifying a value of false (131ms)
│   ✔ test › throws error if local id is not resolved (277ms)
│   ✔ test › finds a file inside a package directory (310ms)
│   ✔ test › supports non-standard extensions (313ms)
│   ✔ test › allows custom options (313ms)
│   ✔ test › generates manual chunks (319ms)
│   ✔ test › resolves dynamic imports (321ms)
│   ✔ test › loads local directories by finding index.js within them (326ms)
│   ✔ test › finds a module with jsnext:main (336ms)
│   ✔ test › supports ./ in entry filename (326ms)
│   ✔ test › finds and uses an .mjs module (330ms)
│   ✔ test › finds and converts a basic CommonJS module (349ms)
│   ✔ test › handles a trailing slash (357ms)
│   ✖ test › handles package side-effects Did not match snapshot
│   ✔ test › ignores deep-import non-modules (389ms)
│   ✔ test › loads package directories by finding index.js within them (402ms)
│   1 test failed
│   test › handles package side-effects
│   /home/hugo/workspace-os/plugins/packages/node-resolve/test/fixtures/test/test.js:219
│   Did not match snapshot
│   Difference:
│     [
│   -   'false-dep1',
│   +   'array-dep1',
│   -   'true-dep1',
│   +   'array-dep3',
│   -   'true-dep2',
│   +   'array-dep5',
│   -   'true-index',
│   +   'array-index',
│   +   'false-dep1',
│   +   'true-dep1',
│   +   'true-dep2',
│   +   'true-index',
│     ]
│  ERROR  Test failed. See above for more details.
└─ Failed in 5s
/home/hugo/workspace-os/plugins/packages/node-resolve:
 ERROR  @rollup/plugin-node-resolve@7.0.0 ci:test: `pnpm run test -- --verbose && pnpm run test:ts`
Exit status 1
Error: Command failed with exit code 1 (EPERM): pnpm run ci:test --filter ./packages
    at makeError (/home/hugo/workspace-os/plugins/node_modules/.pnpm/registry.npmjs.org/execa/2.1.0/node_modules/execa/lib/error.js:59:11)
    at handlePromise (/home/hugo/workspace-os/plugins/node_modules/.pnpm/registry.npmjs.org/execa/2.1.0/node_modules/execa/index.js:112:26)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at async /home/hugo/workspace-os/plugins/scripts/run-changed.js:70:17 {
  command: 'pnpm run ci:test --filter ./packages',
  exitCode: 1,
  exitCodeName: 'EPERM',
  stdout: undefined,
  stderr: undefined,
  failed: true,
  timedOut: false,
  isCanceled: false,
  killed: false,
  signal: undefined
}
Scope: current workspace package

I'm running node 12.14.1 and pnpm 4.7.1 on Debian 9.11

shellscape · 2020-01-13T12:47:18Z

OK thanks for checking. Since we've got a failure verified, I'm going to revert updates to that one and try to tackle it in a separate PR.

shellscape · 2020-01-13T17:24:17Z

@wuweiweiwu @Kocal I removed the node-resolve commit and will handle that separately in another branch/PR. Please have another look and let me know if you're good with merge.

wuweiweiwu

LGTM! very small comment

wuweiweiwu · 2020-01-16T19:12:24Z

-    "magic-string": "^0.25.2",
-    "rollup-pluginutils": "^2.6.0"
+    "@rollup/pluginutils": "^3.0.4",
+    "estree-walker": "1.0.1",


is this meant to be a version lock on 1.0.1?

NotWoods

LGTM with one nit

Co-Authored-By: Tiger Oakes <toakes@mozilla.com>

shellscape added 8 commits January 10, 2020 20:37

chore(alias): update dependencies

e36540f

chore(alias): update dependencies

bcb53d8

chore(buble): update dependencies

579c612

chore(commonjs): update dependencies

5405eea

chore(dsv): update dependencies

8d0eb41

chore(image): update dependencies

1913e7f

chore(inject): update dependencies

73d8ae7

chore(json): update dependencies

e1d317b

shellscape added the pr¹ 🔧 chore label Jan 11, 2020

shellscape requested review from a team, Kocal, NotWoods, btd, pnevares and wuweiweiwu January 11, 2020 03:02

wuweiweiwu approved these changes Jan 11, 2020

View reviewed changes

shellscape and others added 8 commits January 13, 2020 11:41

chore(replace): update dependencies

aca4a94

chore(run): update devDeps

1b08a83

chore(strip): update dependencies

059d1f2

chore(typescript): update devDeps

96c45ff

chore(url): update dependencies

d048a39

chore(virtual): update devDeps

3e47e87

chore(auto-install): correct devDeps

dde1a83

chore(repo): update estree-walker (#143)

ff7d1f3

shellscape force-pushed the chore/update-repo-deps branch from c375173 to ff7d1f3 Compare January 13, 2020 17:08

chore: Merge branch 'master' into chore/update-repo-deps

9e7ef13

shellscape requested a review from wuweiweiwu January 13, 2020 17:24

wuweiweiwu approved these changes Jan 16, 2020

View reviewed changes

NotWoods approved these changes Jan 17, 2020

View reviewed changes

Comment thread packages/auto-install/README.md Outdated

shellscape and others added 3 commits January 18, 2020 15:19

chore: update packages/auto-install/README.md

269f1a3

Co-Authored-By: Tiger Oakes <toakes@mozilla.com>

chore: update estree-walker version range

d4ac25c

Merge branch 'master' into chore/update-repo-deps

75a5f51

shellscape merged commit 1822484 into master Jan 18, 2020

shellscape deleted the chore/update-repo-deps branch January 18, 2020 20:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

update package dependencies#160

update package dependencies#160
shellscape merged 20 commits into
masterfrom
chore/update-repo-deps

shellscape commented Jan 11, 2020

Uh oh!

shellscape commented Jan 11, 2020

Uh oh!

wuweiweiwu commented Jan 11, 2020

Uh oh!

Kocal commented Jan 13, 2020

Uh oh!

shellscape commented Jan 13, 2020

Uh oh!

shellscape commented Jan 13, 2020

Uh oh!

wuweiweiwu left a comment

Uh oh!

wuweiweiwu Jan 16, 2020

Uh oh!

NotWoods left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

shellscape commented Jan 11, 2020

Rollup Plugin Name: many

Description

Uh oh!

shellscape commented Jan 11, 2020

Uh oh!

wuweiweiwu commented Jan 11, 2020

Uh oh!

Kocal commented Jan 13, 2020

Uh oh!

shellscape commented Jan 13, 2020

Uh oh!

shellscape commented Jan 13, 2020

Uh oh!

wuweiweiwu left a comment

Choose a reason for hiding this comment

Uh oh!

wuweiweiwu Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

NotWoods left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants