Improved shouldWrap logic (Closes #304)#355
Merged
Merged
Conversation
lukastaegert
approved these changes
Apr 30, 2020
LarsDenBakker
pushed a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
michaelfig
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Feb 22, 2021
Temporary workaround for rollup/plugins#355
michaelfig
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Feb 22, 2021
Temporary workaround for rollup/plugins#355
michaelfig
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Feb 22, 2021
Temporary workaround for rollup/plugins#355
kriskowal
pushed a commit
to endojs/endo
that referenced
this pull request
Jan 18, 2022
Temporary workaround for rollup/plugins#355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: #304
Description
The older commonjs implementation avoided even looking inside modules that have import/export statements, and thus many
requirestatements in mixed code were not looked into. Even more so when the main entry point was a pure es6 module.The newer code with dynamic require support (#206) removed that disability, but introduced a new issue: ES6 modules with references to
modulewere automatically wrapped with the commonjs helper, as the oldshouldWraplogic did not account for es6 modules being digested.This PR simply fixes that
shouldWrapto avoid touching modules withimport/exportstatements.