Add include directories consistently PRIVATE instead of PUBLIC#201
Closed
cwecht wants to merge 1 commit into
Closed
Add include directories consistently PRIVATE instead of PUBLIC#201cwecht wants to merge 1 commit into
cwecht wants to merge 1 commit into
Conversation
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
clalancette
requested changes
Jan 17, 2024
Contributor
|
I've now merged in #140, which also contains this fix. So I'll close this one out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps in situations in which:
rosidl_python/rosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake
Line 174 in 65538f0
This can happen e.g. if you want to cross-compile ROS2 and want to do it on some CICD setups.
The issue is that right now, e.g. for
std_msgs export_std_msgs__rosidl_generator_pyExport.cmakesets theINTERFACE_INCLUDE_DIRECTORIESproperty ofstd_msgs::std_msgs__rosidl_generator_pyto an absolute path (which causes issues if the folder of your numpy installation changes.With this patch all include directories are consistently added
PRIVATEinstead ofPUBLIC. There shouldn't be a need to expose them anyways.