Skip to content

Detect the old style ttyname_r return type #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobu merged 1 commit into from
Sep 17, 2026
+15 −1
Merged

Detect the old style ttyname_r return type #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ext/io/console/console.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2314,6 +2314,9 @@ console_ttyname(VALUE io)
return rb_usascii_str_new_lit("con");
# elif defined HAVE_TTYNAME_R
{
# ifdef TTYNAME_R_RETURNS_CHAR_P
# define ttyname_r(fd, name, size) (ttyname_r(fd, name, size) == NULL ? errno : 0)
# endif
char termname[1024], *tn = termname;
size_t size = sizeof(termname);
int e;
Expand Down
13 changes: 12 additions & 1 deletion ext/io/console/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,18 @@
end
have_func("rb_category_warn")
have_const("RB_WARN_CATEGORY_DEPRECATED")
win32 or have_func("ttyname_r") or have_func("ttyname")
unless win32
if have_func("ttyname_r")
ret = checking_for("type of ttyname_r()", "%s") {try_link(<<~C) ? "int" : "char *"}
#{cpp_include %<unistd.h>}
int t(void) {char name[1024]; return ttyname_r(0, name, sizeof(name)) % 1024;}
#{MAIN_DOES_NOTHING('t')}
C
$defs << "-DTTYNAME_R_RETURNS_#{ret.tr_cpp}"
else
have_func("ttyname")
end
end
have_func("rb_prepend_module") # not exported by TruffleRuby
vk_tool = find_executable("gperf")
create_makefile("io/console") {|conf|
Expand Down