This repository was archived by the owner on Sep 15, 2026. It is now read-only.
Remove extensions and fully deprecate the gem - #79
Merged
Merged
Conversation
The functionality of this gem was moved into core Ruby starting with Ruby 3.2, and at this point both the C extension and the Java extension define no additional classes or methods. This patch fully removes both extensions, replacing them with a single io/wait.rb that warns about the gem deprecation. All other files have been updated to reflect the removed extensions an deprecation. Fixes ruby#78
Contributor
Author
|
I did not remove the tests, which causes this PR to fail: jruby/jruby#9656 needs to be merged and released to pass the tests, but it needs a release of io-wait before it can be merged. We probably could just remove the tests here too. |
Contributor
Author
Ok, perhaps not. Seems like it passed ok in CI. |
Member
Now the tests also can be removed? |
nobu
added a commit
to nobu/ruby
that referenced
this pull request
Sep 11, 2026
nobu
added a commit
to nobu/ruby
that referenced
this pull request
Sep 11, 2026
Contributor
Author
|
Yes, tests can be removed as well if they are now based in ruby/ruby. We can strip this down to nothing. |
nobu
approved these changes
Sep 13, 2026
nobu
added a commit
to nobu/ruby
that referenced
this pull request
Sep 13, 2026
nobu
added a commit
to nobu/ruby
that referenced
this pull request
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionality of this gem was moved into core Ruby starting with Ruby 3.2, and at this point both the C extension and the Java extension define no additional classes or methods. This patch fully removes both extensions, replacing them with a single io/wait.rb that warns about the gem deprecation. All other files have been updated to reflect the removed extensions an deprecation.
Fixes #78