Increase completion's test coverage and add some minor improvements#412
Merged
Conversation
st0012
changed the title
st0012
changed the title
st0012
force-pushed
the
refactor-completion
branch
from
October 6, 2022 15:55
00a8c69 to
ee9b33c
Compare
Member
Author
peterzhu2118
reviewed
Oct 6, 2022
Member
Author
|
@peterzhu2118 thank you ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
doc_namespace == false)assert_equal's argument order in completion tests (I'll go through other tests in follow up PRs)