Skip to content

🧵 Refactor thread synchronization for sending commands #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 2 commits into from
Jun 7, 2026
Merged

🧵 Refactor thread synchronization for sending commands #692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3121376
🧵 Validate command arguments before locking mutex
nevans Jun 4, 2026
ad85f6e
🧵 Handle invalid response before releasing lock
nevans Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/net/imap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3661,10 +3661,8 @@ def send_command_with_continuations(cmd, *args)
end

def send_command(cmd, *args, &block)
args.each do validate_data _1 end
synchronize do
args.each do |i|
validate_data(i)
end
tag = generate_tag
command = Command[tag:, name: cmd]
put_string(tag + " " + cmd)
Expand All @@ -3681,10 +3679,10 @@ def send_command(cmd, *args, &block)
ensure
remove_response_handler(block) if block
end
rescue InvalidResponseError
disconnect
raise
end
rescue InvalidResponseError
disconnect
raise
end

# NOTE: This must be synchronized with sending the command's final CRLF and
Expand Down
Loading