🧵🥅 Reraise #starttls receiver thread errors with caller's backtrace#711
Merged
Merged
Conversation
An addendum to #691: when `STARTTLS` re-raises a response handler error, that should be raised with the caller thread's backtrace. The original exception will be the cause of the raised exception.
nevans
changed the title
nevans
changed the title
#starttls receiver thread errors with caller's backtrace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An addendum to #691: when
STARTTLSre-raises a response handler error, that should be raised with the caller thread's backtrace. The original exception will be the cause of the raised exception.