Skip to content

Remove needless dependencies#10

Merged
hsbt merged 1 commit into
ruby:masterfrom
eregon:remove-needless-dependencies
Sep 28, 2022
Merged

Remove needless dependencies#10
hsbt merged 1 commit into
ruby:masterfrom
eregon:remove-needless-dependencies

Conversation

@eregon

@eregon eregon commented Feb 2, 2022

Copy link
Copy Markdown
Member

These are default gems, so there is no need to explicitly depend on them,
and depending on them is actually harmful: https://bugs.ruby-lang.org/issues/18567.

These are default gems, so there is no need to explicitly depend on them,
and depending on them is actually harmful: https://bugs.ruby-lang.org/issues/18567.
@hsbt

hsbt commented Feb 21, 2022

Copy link
Copy Markdown
Member

same as ruby/net-imap#56 (comment)

@hsbt hsbt merged commit a5e6d1d into ruby:master Sep 28, 2022
@hsbt

hsbt commented Sep 28, 2022

Copy link
Copy Markdown
Member

I will revert this change when we remove digest or/and timeout from the Ruby stdlibs.

@eregon

eregon commented Sep 28, 2022

Copy link
Copy Markdown
Member Author

I will revert this change when we remove digest or/and timeout from the Ruby stdlibs.

Is there any plan to do so? That sounds extremely disruptive and never worth it.
digest/timeout are used by so many Ruby programs, and they all assume it's part of stdlib.

@hsbt

hsbt commented Sep 28, 2022

Copy link
Copy Markdown
Member

digest/timeout are used by so many Ruby programs, and they all assume it's part of stdlib.

Yes, Because I added them to dependencies. But You refuse it. I have no idea to care it.

@eregon

eregon commented Sep 28, 2022

Copy link
Copy Markdown
Member Author

Right, but thousands of Ruby devs would need to add the dependency, not just in a few default gems.
Anyway, I was just curious if there was already a discussion on Redmine (or a plan documented somewhere) to remove digest/timeout from stdlib and what is the rationale. I suspect the gain/cost is very low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants