added type of Float::INFINITY - #1080
Closed
HoneyryderChuck wants to merge 1 commit into
Closed
Conversation
Merged
Member
|
@HoneyryderChuck Thank you for opening this PR. 🙏 I opened another PR for this since this is not updated with CI failure. |
soutaro
pushed a commit
that referenced
this pull request
Jul 27, 2026
Both are declared in core/float.rbs but raise NameError at runtime: * Float::ROUNDS was removed from Ruby in 3.0 (ruby/ruby#2953). * Float::Infinity was added in #1095 (which superseded #1080). Ruby does not define this constant: looking at the Ruby of that period (3.1), numeric.c defines Float::INFINITY but not Float::Infinity, and it still raises NameError today. Also add singleton constant type assertions for the remaining Float constants, so their declared types stay verified against the runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.