Assume that rbs files are encoded in UTF-8 - #493
Merged
Conversation
Formerly, rake fails when `LANG=C` because ruby assumes the input files are encoded in US-ASCII. By this change, all rbs files are read as UTF-8. Nowadays, I think a major part of ruby (and RBS) code are in UTF-8. So this gives good first aid for the issue. A magic comment like `# encoding: something` may be needed in RBS as well as ruby code, but I think it requires further discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formerly, rake fails when
LANG=Cbecause ruby assumes the input filesare encoded in US-ASCII.
By this change, all rbs files are read as UTF-8.
Nowadays, I think a major part of ruby (and RBS) code are in UTF-8. So
this gives good first aid for the issue.
A magic comment like
# encoding: somethingmay be needed in RBS aswell as ruby code, but I think it requires further discussion.