Nodoc implementation details - #265
Merged
Merged
Conversation
Earlopain
commented
Sep 15, 2026
| require_relative "left_right_token_count" | ||
|
|
||
| module SyntaxSuggest | ||
| class GetParseErrors |
Collaborator
Author
There was a problem hiding this comment.
Still around from when ripper was used. Instead of doing nodoc I took the oportunity and just inlined it
|
|
||
| expect(explain.missing).to eq([]) | ||
| expect(explain.errors).to eq(GetParseErrors.errors(source)) | ||
| expect(explain.errors).to include(/unexpected 'end'/) |
Collaborator
Author
There was a problem hiding this comment.
Not sure what this test tests anymore, since ripper is now gone.
Collaborator
There was a problem hiding this comment.
This is asserting that we fallback to the parser error when we couldn't diagnose it via unbalanced tokens i.e. ( missing ).
Earlopain
force-pushed
the
nodoc-stuff
branch
2 times, most recently
from
September 15, 2026 17:59
bef0ef5 to
de76e3b
Compare
Just leaves `SyntaxSuggest.handle_error` and `SyntaxSuggest::VERSION` visible. Removes some public/private annotations since ony public stuff is now documented.
Earlopain
force-pushed
the
nodoc-stuff
branch
from
September 15, 2026 18:00
de76e3b to
18c62ce
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just leaves
SyntaxSuggest.handle_errorandSyntaxSuggest::VERSIONvisible. Removes some public/private annotations since ony public stuff is now documented.I occasionally get some syntax-suggest recommendations when searching on https://docs.ruby-lang.org/. They are always irrelevant and not supposed to be used outside of syntax-suggest itself.
[skip changelog]