Skip to content

Report super outside a method instead of crashing #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sinsoku wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −3
Open

Report super outside a method instead of crashing #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lib/typeprof/core/ast/call.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,13 @@ def install0(genv)
end

if @forwarding_arguments
forward_a_args = (@lenv.forward_args || raise).to_actual_arguments(
forward_args = @lenv.forward_args
# `...` needs a method definition, so only a bare `super` can reach here
@changes.add_diagnostic(:code_range, "implicit argument passing of super is not supported here") unless forward_args
end

if forward_args
forward_a_args = forward_args.to_actual_arguments(
genv,
@changes,
self,
Expand Down Expand Up @@ -211,11 +217,11 @@ def install0(genv)
blk_ty = @block_pass.install(genv)
elsif @anonymous_block_forwarding
blk_ty = @lenv.get_var(:"*anonymous_block")
elsif @forwarding_arguments
elsif forward_args
blk_ty = forward_a_args.block
end

if @forwarding_arguments
if forward_args
a_args = a_args.with_block(blk_ty, omittable: !@block_body && !@block_pass && !@anonymous_block_forwarding)
else
a_args = a_args.with_block(blk_ty)
Expand Down
9 changes: 9 additions & 0 deletions scenario/diagnostics/super-outside-method.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
## update
define_method(:foo) do |x|
super
end

## diagnostics
(1,0)-(1,13): undefined method: Object#define_method
(2,2)-(2,7): implicit argument passing of super is not supported here
(2,2)-(2,7): undefined method: Object#define_method
Loading