Summary
Two caller workflows in this repo use secrets: inherit when calling rubykatzen/releaser reusable workflows:
.github/workflows/dependabot-automerge.yml -> rubykatzen/releaser/.../dependabot-automerge-shared.yml@v0.5
.github/workflows/telegram-release-notify.yml -> rubykatzen/releaser/.../telegram-release-notify-shared.yml@v0.5
Why change
secrets: inherit passes every secret available in this repo's Actions context to the called reusable workflow, not just what it actually needs — notably dependabot-automerge.yml also runs on pull_request_target, a trigger that already warrants extra caution around what it has access to. Explicit, least-privilege secret passing is safer and makes the caller file an accurate source of truth for what it actually uses.
Proposed change
Replace secrets: inherit in both files with an explicit mapping matching whatever secrets: each corresponding -shared.yml declares under on: workflow_call, e.g. for the telegram one:
secrets:
TELEGRAM_BOT_TOKEN: ${{ secrets.TELEGRAM_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.TELEGRAM_CHAT_ID }}
Scope
Same pattern found across the org — companion issues filed in rubykatzen/releaser, rubykatzen/homebrew-tap, and rubykatzen/baseline.
Summary
Two caller workflows in this repo use
secrets: inheritwhen callingrubykatzen/releaserreusable workflows:.github/workflows/dependabot-automerge.yml->rubykatzen/releaser/.../dependabot-automerge-shared.yml@v0.5.github/workflows/telegram-release-notify.yml->rubykatzen/releaser/.../telegram-release-notify-shared.yml@v0.5Why change
secrets: inheritpasses every secret available in this repo's Actions context to the called reusable workflow, not just what it actually needs — notablydependabot-automerge.ymlalso runs onpull_request_target, a trigger that already warrants extra caution around what it has access to. Explicit, least-privilege secret passing is safer and makes the caller file an accurate source of truth for what it actually uses.Proposed change
Replace
secrets: inheritin both files with an explicit mapping matching whateversecrets:each corresponding-shared.ymldeclares underon: workflow_call, e.g. for the telegram one:Scope
Same pattern found across the org — companion issues filed in
rubykatzen/releaser,rubykatzen/homebrew-tap, andrubykatzen/baseline.