Pinning clippy on 1.29.1 stable to avoid more uneccesary CI breakage#49
Merged
Conversation
killercup
approved these changes
Oct 4, 2018
killercup
left a comment
killercup
left a comment
Collaborator
There was a problem hiding this comment.
Couldn't have written it better myself
| script: | ||
| - cargo fmt --all -- --write-mode=diff | ||
| - rust: 1.29.1 | ||
| env: CLIPPY=YESPLEASE |
Collaborator
There was a problem hiding this comment.
I really like how this is now uppercase
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a 🐛 bug fix.
The clippy-preview works on the stable channel now so we can pin it on 1.29.1 and use it for lints and formatting without having to bump clippy and or nightly every so often.
Checklist