zip_mut_with 'f' order#754
Merged
Merged
Conversation
jturner314
reviewed
Nov 18, 2019
jturner314
approved these changes
Dec 5, 2019
Member
jturner314
left a comment
jturner314
left a comment
There was a problem hiding this comment.
This PR looks good to me. The CI failure should be resolved by #762.
Member
|
I re-ran CI and it passed now that #762 resolved the clippy warnings. Thanks for this PR @nilgoyette! It's always nice to boost performance with internal improvements like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As adviced by @jturner314 in #749, I now use
as_slice_memory_orderinzip_mut_with_same_shapefor same-order arrays. (I also wanted to optimizezip_indexedbut it's more complex so I'll probably do it later)I modified
zip_mut_with_same_shapemore than I intended at first because there were some useless statements. At that point, we have same-shape arrays, so they have the same length, which make the slicing useless.The bench I added show that 'cc' is not slower than it was and 'ff' is as fast as 'cc'. On windows and WSL.