fix(s3): preserve bucket service error details#211
Open
overtrue wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes loss of backend S3 service error details for bucket-level operations by routing list_buckets and create_bucket failures through the shared SDK error formatter, ensuring service error codes (e.g., from x-amz-error-code) are preserved in user-facing errors.
Changes:
- Use
S3Client::format_sdk_errorwhen mapping AWS SDK errors forlist_bucketsandcreate_bucket. - Add regression tests asserting that bucket listing/creation errors include the service error code in the resulting
Error::Networkmessage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3858156 to
512086a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #210.
Evidence / reproduction
Issue #210 shows both
rc mb local/test/andrc ls localreturning onlyNetwork error: service erroragainst a RustFS endpoint. The bucket-level SDK paths were usingSdkError::to_string(), which can collapse service responses to that generic text.Root cause
list_bucketsandcreate_bucketdid not use the existing SDK error formatter, so backend error codes from headers such asx-amz-error-codewere lost.Fix
Use the shared
format_sdk_errorhelper for bucket listing and creation errors, and add regression tests proving service error codes are preserved.Validation
cargo test -p rc-s3 preserves_service_error_code --libcargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspacegit diff --check