Skip to content

fix(scatterlab-prebuild-android): sdkmanager 스텝의 pipefail 자해를 고친다 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdwkr merged 2 commits into from
Sep 11, 2026
Merged

fix(scatterlab-prebuild-android): sdkmanager 스텝의 pipefail 자해를 고친다 #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
332266b
fix(scatterlab-prebuild-android): sdkmanager 스텝의 pipefail 자해를 고친다
kdwkr Sep 11, 2026
2600b9c
fix(scatterlab-prebuild-android): 라이선스 수락 실패를 삼키지 않는다
kdwkr Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions .github/workflows/scatterlab-prebuild-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,31 @@ jobs:
exit 1
fi
echo "sdkmanager: $SDKMANAGER"
yes 2>/dev/null | "$SDKMANAGER" --install 'cmake;3.30.5' 'ndk;27.1.12297006'

# `yes | sdkmanager` cannot be used under `pipefail`: when sdkmanager exits first,
# `yes` dies of SIGPIPE (141) and pipefail makes that the pipeline's status, so a
# successful install still fails the step. With pipefail off the pipeline reports
# sdkmanager's own status instead, so SIGPIPE is ignored and a real licence
# failure is still caught - no `|| true`, which would swallow both.
set +o pipefail
if ! yes 2>/dev/null | "$SDKMANAGER" --sdk_root="$ANDROID_HOME" --licenses >/dev/null; then
set -o pipefail
echo "::error::sdkmanager --licenses failed; cmake/ndk cannot be installed"
exit 1
fi
set -o pipefail

"$SDKMANAGER" --sdk_root="$ANDROID_HOME" --install 'cmake;3.30.5' 'ndk;27.1.12297006'

# Prove it landed rather than trusting sdkmanager's exit code, which stays 0 for
# a package it silently declined to install.
for required in "$ANDROID_HOME/cmake/3.30.5" "$ANDROID_HOME/ndk/27.1.12297006"; do
[ -d "$required" ] || { echo "::error::$required is still missing after sdkmanager ran"; exit 1; }
if [ ! -d "$required" ]; then
echo "::error::$required is still missing after sdkmanager ran"
echo "cmake dirs:"; ls -1 "$ANDROID_HOME/cmake" 2>/dev/null || echo " (none)"
echo "ndk dirs:"; ls -1 "$ANDROID_HOME/ndk" 2>/dev/null || echo " (none)"
exit 1
fi
done
echo "cmake 3.30.5 and ndk 27.1.12297006 present"

Expand Down