Skip to content

fix(scatterlab-prebuild-android): build 잡에 JDK를 설치한다 - #5

Merged
kdwkr merged 1 commit into
scatterlab/0.87.1from
daewoon/android-build-jdk
Sep 11, 2026
Merged

fix(scatterlab-prebuild-android): build 잡에 JDK를 설치한다#5
kdwkr merged 1 commit into
scatterlab/0.87.1from
daewoon/android-build-jdk

Conversation

@kdwkr

@kdwkr kdwkr commented Sep 11, 2026

Copy link
Copy Markdown
Member

Summary:

파이프라인 첫 dry-run(run 34550291692)이 Gradle 실행 스텝에서 죽었다:

ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.

리눅스 러너 이미지에 JDK 가 없다. prepare 잡은 소비자 스모크 테스트가 ./gradlew 를 쓰기 때문에 actions/setup-java 를 들고 있었는데, 정작 ReactAndroid 를 빌드하는 build 잡에는 빠져 있었다. prepare 와 같은 temurin 17 로 맞춰 두 잡이 같은 툴체인을 쓰게 한다.

그 앞의 prepare 잡은 전부 통과했다 — 버전 일치 검사, setup-java, 그리고 소비자 스모크 13케이스가 CI 에서 처음 돌아 스킵 없이 통과했다(러너에 python3 존재 확인). 로그의 yarn cache is not found·Cache not found for input keys: scatterlab-ccache-android-... 는 첫 실행이라 정상이다.

Changelog:

[INTERNAL] [FIXED] - Install a JDK in the Android prebuilt workflow's build job

Test Plan:

$ python3 -c "import yaml;d=yaml.safe_load(open('.github/workflows/scatterlab-prebuild-android.yml'));print('yaml ok');print('jobs with setup-java:', [...])"
yaml ok
jobs with setup-java: ['prepare', 'build']

actionlint 은 기존 노이즈(self-hosted 러너 라벨, SC2129, 상류 yarn-install 액션의 description 누락) 외에 새 경고 없음.

머지 후 같은 dry-run 을 다시 돌려 build 가 끝까지 가는지, 특히 verify_symbol 게이트가 상류 base AAR 에서 visibleTextEnd 0건 · 우리 AAR 에서 1건 이상을 실제로 세는지 확인한다.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • 개선 사항
    • Android 빌드가 Java 17 환경에서 실행되도록 빌드 환경을 명시했습니다.

첫 dry-run(run 34550291692)이 Gradle 실행에서 죽었다:

    ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.

리눅스 러너 이미지에 JDK가 없다. `prepare` 잡은 소비자 스모크 테스트가
`./gradlew` 를 쓰느라 `actions/setup-java` 를 들고 있었지만, 정작
ReactAndroid 를 빌드하는 `build` 잡에는 없었다. 같은 버전·배포판(temurin 17)
으로 맞춰 두 잡이 같은 툴체인을 쓰게 한다.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 98cc08b9-eab2-4d50-a901-4dccbf203e27

📥 Commits

Reviewing files that changed from the base of the PR and between 18afe74 and 164d700.

📒 Files selected for processing (1)
  • .github/workflows/scatterlab-prebuild-android.yml

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

Android 사전 빌드 작업이 Gradle 실행 전에 actions/setup-java@v5로 Temurin Java 17을 설정합니다.

Changes

Android 빌드 환경

Layer / File(s) Summary
Gradle 실행 전 Java 17 설정
.github/workflows/scatterlab-prebuild-android.yml
build 작업이 Gradle 실행 전에 Temurin Java 17을 설정합니다.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 164d7

Android prebuilds now have the required Java toolchain configured, with no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 Android prebuild workflow의 build 작업에 JDK 17을 설치하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch daewoon/android-build-jdk

토끼가 Java 17을 준비해요
Gradle은 새 환경에서 달려요
Temurin이 길을 밝혀요
Android 빌드가 씩씩해요
당근처럼 안정적으로 완료돼요

Comment @coderabbitai help to get the list of available commands.

@kdwkr
kdwkr merged commit 3aa63ab into scatterlab/0.87.1 Sep 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant