Skip to content

footer updates - #7

Open
drammock wants to merge 12 commits into
scientific-python:mainfrom
drammock:footer
Open

footer updates#7
drammock wants to merge 12 commits into
scientific-python:mainfrom
drammock:footer

Conversation

@drammock

@drammock drammock commented Jul 18, 2026

Copy link
Copy Markdown
Member
  1. changes statistical -> scientific in the footer text
  2. adds a new plugin to pull in the footer links and social icons/links from a JSON file
  3. tweaks spacing/breakpoints/CSS

@drammock

This comment was marked as outdated.

@drammock

drammock commented Jul 19, 2026

Copy link
Copy Markdown
Member Author

Current state:

Screenshot 2026-07-19 at 11-05-02 https __foo bar

TODO:

  • I cannot get the :columns: property of grid-items to have any effect, so to shrink the space allocated to the logo I had to embed another sub-grid for the logo + description text
  • Having trouble adjusting the spacing between footer links. Right now it seems to be governed by the gap-4 class on the outer grid, and adding e.g. gap-1 to the inner grid didn't override that
  • add the social icons (and copyright notice?) to the rightmost cell
  • other general tweaking of spacing; could resort to custom classes + CSS if necessary but was hoping to get something nice-looking using only the grid system and existing gap-*, my-* and mx-* classes

@stefanv (or anyone else!) feel free to push commits here to get it over the line

@drammock

This comment was marked as outdated.

@drammock

Copy link
Copy Markdown
Member Author

@lundybernard feel free also to have a look and see if there are any tweaks you want to suggest

@drammock

Copy link
Copy Markdown
Member Author
Screenshot 2026-07-23 at 12-22-08 foo bar

@lundybernard

Copy link
Copy Markdown

drammock#2

I did another review, flagged a few minor issues with suggested fixes.
These are mostly minor under-the-hood changes that site visitors would never notice.

Everything looks and feels good when I run it locally check it by hand, social links work properly.
There are a few gaps in the footer-links on the Test Site, which I assume is fine; SPECs, Press kit, etc. are not found, but target the appropriate site url.

@drammock

Copy link
Copy Markdown
Member Author

I did another review, flagged a few minor issues with suggested fixes.

thanks @lundybernard. I'll take a look tomorrow. FYI your PR is against drammock/main instead of drammock/footer but it's fine, i can easily merge/cherry-pick the commits locally and push them where they need to go.

lundybernard and others added 4 commits July 24, 2026 11:43
static_files is unnecessary: the icons are referenced from image AST
nodes, so the build hashes and copies them into /build automatically
(the static copy also landed at /icons/, not /assets/icons/, and
nothing referenced it). Exclude assets/icons/README.md, which was
rendered as a site page at /assets/icons/readme.

Assisted-by: claude-code:claude-fable-5
@drammock

Copy link
Copy Markdown
Member Author

OK I've incorporated all of @lundybernard's changes. Should be ready to go. Demo of breakpoints:

Screencast.2026-07-24.11.56.32.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants