Skip to content

Fix priority of LoggerPreprocessor#447

Merged
ctrueden merged 1 commit into
masterfrom
loggerpreprocessor-priority
Dec 12, 2022
Merged

Fix priority of LoggerPreprocessor#447
ctrueden merged 1 commit into
masterfrom
loggerpreprocessor-priority

Conversation

@imagejan

Copy link
Copy Markdown
Member

Logger parameters should be processed before InitPreprocessor, so that plugins can use a Logger in their initializer.

Closes #446.

Logger parameters should be processed before InitPreprocessor, so that plugins can use a Logger in their initializer.
@imagejan imagejan requested a review from ctrueden December 12, 2022 14:01
@ctrueden

Copy link
Copy Markdown
Member

@imagejan Thanks! So the change to VERY_HIGH ends up moving the LoggerPreprocessor to before the InitPreprocessor (which is HIGH) but still after the ServicePreprocessor (which is 2*VERY_HIGH). That's intended, right?

@ctrueden ctrueden merged commit 9564503 into master Dec 12, 2022
@ctrueden ctrueden deleted the loggerpreprocessor-priority branch December 12, 2022 16:30
@imagejan

Copy link
Copy Markdown
Member Author

Thanks for merging, @ctrueden!
Exactly, moving LoggerPreprocessor priority in between ServicePreprocessor and InitPreprocessor was intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logger parameters can't be used while initializing DynamicCommands

2 participants