Only convert to array types when it is possible#449
Merged
ctrueden merged 1 commit intoDec 14, 2022
Conversation
gselzer
force-pushed
the
448-convertservice-eagerly-converts-stuff-to-arrays
branch
from
dad61cd to
45c3330
Compare
Member
Author
|
@ctrueden how do these changes fare with backwards compatibility? |
gselzer
force-pushed
the
448-convertservice-eagerly-converts-stuff-to-arrays
branch
from
45c3330 to
a639bcc
Compare
ctrueden
deleted the
448-convertservice-eagerly-converts-stuff-to-arrays
branch
Member
I don't foresee any problems! The tests all passed, so it must be bug-free! 🏆 |
ctrueden
added a commit
that referenced
this pull request
Feb 1, 2023
This test is no longer applicable, at least with the current conversion logic that now handles arrays and collections as of #449 et al. There is a substantial discrepancy right now between what DefaultConverter reports as convertible via canConvert versus what it actually *does* support converting via the convert methods. But that's an issue for another day!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #448.
Instead of reporting that
DefaultConvertercan convert anything to an array, we only report that we can convert things thatArrayUtils.toCollectioncan actually convert into aCollection.One other concern is whether the case logic might lead to action-at-a-distance errors.