Use a better value for the default groupId#4
Merged
Merged
Conversation
This project migrated from ImageJ2, where net.imagej was an intuitive choice for default groupId. But the project is part of the Scijava scripting framework now, so a groupId matching that fact makes more sense. We use org.scijava.scripting.java, rather than only org.scijava, to avoid potential name clashes with actual SciJava projects such as scijava-common, scripting-java, etc.
Member
Author
|
@dscho Thoughts? |
dscho
added a commit
that referenced
this pull request
Sep 26, 2014
Use a better value for the default groupId
Contributor
|
Makes sense, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project migrated from ImageJ2, where
net.imagejwas an intuitivechoice for default groupId. But the project is part of the SciJava
scripting framework now, so a groupId matching that fact makes more
sense.
We use
org.scijava.scripting.java, rather than onlyorg.scijava, toavoid potential name clashes with actual SciJava projects such as
scijava-common,scripting-java, etc.