Raise a clear error when a da_nhoods design has no residual degrees of freedom - #1077
Open
Zethson wants to merge 1 commit into
Open
Raise a clear error when a da_nhoods design has no residual degrees of freedom#1077Zethson wants to merge 1 commit into
Zethson wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
=======================================
Coverage 79.46% 79.47%
=======================================
Files 53 53
Lines 7545 7556 +11
=======================================
+ Hits 5996 6005 +9
- Misses 1549 1551 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1075.
With one sample per condition, edgeR's
estimateDispsets the dispersion to NA andglmQLFitthen fails withmissing value where TRUE/FALSE needed, which gives no hint about the actual problem.da_nhoodsnow checks that the design leaves residual degrees of freedom and raises aValueErrorpointing at the missing replication, for all three solvers.