Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

fix: Ensure cast toString before trim on buffer#656

Merged
pgrzesik merged 1 commit into
masterfrom
fix-trim-on-buffer
Dec 3, 2021
Merged

fix: Ensure cast toString before trim on buffer#656
pgrzesik merged 1 commit into
masterfrom
fix-trim-on-buffer

Conversation

@pgrzesik

@pgrzesik pgrzesik commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Ensure proper cast to string before trim call as reported in: #648 (comment)

@pgrzesik pgrzesik added the bug label Dec 2, 2021
@pgrzesik pgrzesik self-assigned this Dec 2, 2021
@obataku

obataku commented Dec 3, 2021

Copy link
Copy Markdown

thanks for addressing this so quickly

@pgrzesik pgrzesik requested a review from medikoo December 3, 2021 07:36
@pgrzesik

pgrzesik commented Dec 3, 2021

Copy link
Copy Markdown
Contributor Author

Sure thing, sorry for missing it on the first PR @obataku

@f00f

f00f commented Dec 3, 2021

Copy link
Copy Markdown

👍

That bug bit me, too.

@medikoo medikoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pgrzesik pgrzesik merged commit f60eed1 into master Dec 3, 2021
@pgrzesik pgrzesik deleted the fix-trim-on-buffer branch December 3, 2021 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants