Fix FRANKENPHP_CONFIG environment variable typo in FrankenPHP Dockerfile - #702
Merged
jaydrogers merged 2 commits intoSep 10, 2026
Conversation
The Dockerfile declared FRANKEN_PHP_CONFIG, but the Caddyfile and the docs reference FRANKENPHP_CONFIG. Rename the ENV so the default matches the variable Caddy actually reads.
jaydrogers
changed the base branch from
main
to
release/webserver-improvements-and-fixes
September 10, 2026 18:28
Member
|
Good catch, thanks! |
jaydrogers
merged commit Sep 10, 2026
06a660a
into
serversideup:release/webserver-improvements-and-fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Renames the
FRANKEN_PHP_CONFIGENV insrc/variations/frankenphp/DockerfiletoFRANKENPHP_CONFIG.Why
The Dockerfile declares the default as
FRANKEN_PHP_CONFIG="", but everything else in the project usesFRANKENPHP_CONFIG:src/variations/frankenphp/etc/frankenphp/Caddyfilereads{$FRANKENPHP_CONFIG}inside thefrankenphp { }global blockFRANKENPHP_CONFIGThe typo was introduced in #527 when the default Caddyfile was added. Setting
FRANKENPHP_CONFIGat runtime already works because Caddy reads it directly from the environment, so this only corrects the declared default in the image and removes a misleading, unused variable fromdocker inspectoutput.Scope
One-line change. No behavior change for users who already set
FRANKENPHP_CONFIGthemselves.