fix: add missing "> /dev/" dangerous command check in s09/s10/s11#286
Open
123456wda wants to merge 1 commit into
Open
fix: add missing "> /dev/" dangerous command check in s09/s10/s11#286123456wda wants to merge 1 commit into
123456wda wants to merge 1 commit into
Conversation
s09_agent_teams.py, s10_team_protocols.py, and s11_autonomous_agents.py were missing the "> /dev/" entry in their dangerous command blocklist. This is present in s01, s06, s12, and s_full but was dropped when s09-s11 were written, creating a security regression where commands like `echo y > /dev/sda` could bypass the blocklist.
|
@123456wda is attempting to deploy a commit to the crazyboym's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s09_agent_teams.py,s10_team_protocols.py, ands11_autonomous_agents.pyare missing the"> /dev/"entry in their_run_bash()dangerous command blocklistecho y > /dev/sdacould bypass the blocklistChanges
agents/s09_agent_teams.py"> /dev/"to dangerous list in_run_bash()agents/s10_team_protocols.py"> /dev/"to dangerous list in_run_bash()agents/s11_autonomous_agents.py"> /dev/"to dangerous list in_run_bash()Test plan
python -m py_compile agents/s09_agent_teams.pypassespython -m py_compile agents/s10_team_protocols.pypassespython -m py_compile agents/s11_autonomous_agents.pypasses