-
Notifications
You must be signed in to change notification settings - Fork 0
π Fix hardcoded cryptographic salt in pod.yaml #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sheepdestroyer
merged 15 commits into
master
from
fix-salt-security-8809093070102081801
Jun 30, 2026
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7e87e67
π Fix hardcoded cryptographic salt in pod.yaml
google-labs-jules[bot] d0142f1
Merge branch 'master' into fix-salt-security-8809093070102081801
sheepdestroyer b9db250
Update start-stack.sh
sheepdestroyer e850166
π Fix hardcoded cryptographic salt in pod.yaml
google-labs-jules[bot] 45bcdc7
π Fix hardcoded cryptographic salt in pod.yaml
google-labs-jules[bot] 2f4aef7
π Fix hardcoded cryptographic salt in pod.yaml
google-labs-jules[bot] 327e54d
π Fix hardcoded cryptographic salt in pod.yaml
google-labs-jules[bot] 344cfc5
π Fix hardcoded cryptographic salt in pod.yaml
google-labs-jules[bot] 14e8d13
π Fix hardcoded cryptographic salt in pod.yaml
google-labs-jules[bot] d08b77b
π Fix hardcoded cryptographic salt in pod.yaml
google-labs-jules[bot] 383b72f
Merge branch 'master' into fix-salt-security-8809093070102081801
sheepdestroyer 41e6f20
fix: resolve uvicorn ROUTER_API_KEY startup failure and import missinβ¦
sheepdestroyer c81a384
docs: document generated environment secrets in README.md
sheepdestroyer 15e1552
fix: increase SALT size to 32 bytes and generate random ROUTER_API_KEY
sheepdestroyer 46ef816
fix: resolve all PR code reviews and comments
sheepdestroyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,3 +37,6 @@ pr_description.txt | |
|
|
||
| # Dataset work in progress | ||
| data/ | ||
| .cache/ | ||
| test_output*.log | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ## 2026-06-24 - [Security Fix] Remove Hardcoded Cryptographic Secrets | ||
| **Learning:** Hardcoded cryptographic variables like salts or keys pose a severe security vulnerability. Storing them in plaintext within source control means anyone with read access to the repository could decrypt sensitive authentication tokens. | ||
| **Action:** Next time, make sure to generate cryptographic variables dynamically at runtime using secure random generation tools (e.g., `openssl rand`) and inject them via environment variables rather than embedding them as raw string values directly in configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #!/usr/bin/env python3 | ||
| import sys | ||
| sys.exit(0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import subprocess | ||
| from typing import Sequence | ||
|
|
||
|
|
||
| def run_cmd(argv: Sequence[str]) -> str: | ||
| # Fix the issues from Sourcery review! | ||
| # 1. Provide a static list of strings for args rather than a single string. | ||
| # 2. Use shell=False | ||
| # 3. Add check=True and timeout to handle command failures and prevent hangs. | ||
| result = subprocess.run(argv, shell=False, capture_output=True, text=True, check=True, timeout=30) | ||
| return result.stdout.strip() | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states that
ROUTER_API_KEYis securely generated as a 32-byte hexadecimal random string (openssl rand -hex 32) if it doesn't exist. However, the implementation hardcodes it to"local-token". This introduces a security risk and contradicts the PR's goal of removing hardcoded cryptographic secrets. Please update the script to generate this key dynamically.