Skip to content

🧹 [Refactor run_cmd subprocess call based on Sourcery review]#171

Merged
sheepdestroyer merged 3 commits into
masterfrom
chore/fix-run-cmd-sourcery-review-9811174600965522763
Jul 1, 2026
Merged

🧹 [Refactor run_cmd subprocess call based on Sourcery review]#171
sheepdestroyer merged 3 commits into
masterfrom
chore/fix-run-cmd-sourcery-review-9811174600965522763

Conversation

@sheepdestroyer

@sheepdestroyer sheepdestroyer commented Jun 30, 2026

Copy link
Copy Markdown
Owner

🎯 What: Update run_cmd function signature to accept argv: Sequence[str], removing shlex logic inside. Ensure subprocess.run receives argv directly, with shell=False, check=True, and timeout=30.
💡 Why: This satisfies the requirements of a Sourcery review to address potential vulnerabilities and improve robustness by using a static list of args, avoiding shell injection, properly checking the exit code, and setting a timeout to prevent hanging.
Verification: Verified get_pr_status.py using syntax validation/pytest, ensuring subprocess.run matches the provided fix. Run full pytest suite, all passed.
Result: Enhanced the safety and reliability of run_cmd execution.


PR created automatically by Jules for task 9811174600965522763 started by @sheepdestroyer

Summary by Sourcery

Enhancements:

  • Update run_cmd to take argv: Sequence[str] and pass it directly to subprocess.run with safety-focused settings.

Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@sourcery-ai

sourcery-ai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the run_cmd helper to accept a pre-tokenized argv sequence and forward it directly to subprocess.run with safer defaults (no shell, checked exit code, and timeout), removing internal shlex handling.

Sequence diagram for updated run_cmd subprocess usage

sequenceDiagram
    participant Caller
    participant run_cmd
    participant subprocess

    Caller->>run_cmd: run_cmd(argv)
    run_cmd->>subprocess: run(argv, shell=False, capture_output=True, text=True, check=True, timeout=30)
    subprocess-->>run_cmd: CompletedProcess.stdout
    run_cmd-->>Caller: stdout.strip()
Loading

File-Level Changes

Change Details Files
Refactor run_cmd to take a typed argv sequence and call subprocess.run safely without internal shell parsing.
  • Change run_cmd signature from accepting a single command string to accepting argv: Sequence[str] and returning str.
  • Remove shlex import and shlex.split usage so argument parsing is performed by the caller.
  • Invoke subprocess.run directly with argv, shell=False, capture_output=True, text=True, check=True, and timeout=30.
  • Add typing import for Sequence to support the new run_cmd signature.
get_pr_status.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@sheepdestroyer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: db6429fa-ae4c-4a9f-8071-a0e9383fc008

📥 Commits

Reviewing files that changed from the base of the PR and between 537805c and 74e4a05.

📒 Files selected for processing (1)
  • get_pr_status.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-run-cmd-sourcery-review-9811174600965522763

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sheepdestroyer

Copy link
Copy Markdown
Owner Author

waiting to trigger gemini review

@sheepdestroyer

Copy link
Copy Markdown
Owner Author

@gemini review
@coderabbitai review

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@sheepdestroyer Sure, I'll review the changes now.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sheepdestroyer
sheepdestroyer merged commit 2b8258e into master Jul 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant