-
Notifications
You must be signed in to change notification settings - Fork 0
feat: parameterize ports/pod, fix valkey healthcheck, address all review comments #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3084c68
feat: parameterize all ports and pod name for parallel prod/dev deplo…
143d8ef
Merge branch 'master' into chore/learn-deployment-guidelines
sheepdestroyer 9e86358
fix: default DATA_ROOT to WORKDIR/data instead of WORKDIR
38d03b4
fix: move dataset mount under DATA_ROOT as datasets/
bce02a6
fix: remove dev-data workaround — DATA_ROOT now defaults to data/
24a7012
fix: consolidate gitignore — all data dirs now under data/
2fe9545
fix: router reads ports from env vars (LITELLM_PORT, VALKEY_CACHE_POR…
fff4592
fix: router image configurable via ROUTER_IMAGE env var; router reads…
02182ff
fix: render router config.yaml with LITELLM_PORT placeholder at deplo…
f4befbb
fix: replace tcpSocket probes with valkey-cli exec probes, switch to …
5f4c87e
fix: add -p VALKEY_CACHE_PORT_PLACEHOLDER to valkey-cache probes
1afa7c1
fix: address PR #248 and #249 review comments
fdfd49f
Update litellm/entrypoint.py
sheepdestroyer 45e1e50
Update router/main.py
sheepdestroyer 4865655
Update router/main.py
sheepdestroyer 8e13aff
Update router/main.py
sheepdestroyer 93a839d
fix: address PR #250 review comments
69a3b84
Update start-stack.sh
sheepdestroyer 2e82b4a
Update scripts/backup.sh
sheepdestroyer a84638b
Update start-stack.sh
sheepdestroyer a1f3a2d
fix: repair CI test and start-stack.sh logic from direct-applied commits
bbc56ee
chore: add .venv/ to .gitignore
008b15b
Update litellm/entrypoint.py
sheepdestroyer dab8501
fix: address PR#252 review comments — safe_pod_teardown, .env key str…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Dev environment overlay — sourced AFTER .env to override prod values | ||
| # Secrets are inherited from .env; only env-specific config is set here. | ||
|
|
||
| # Pod identity | ||
| POD_NAME="dev-router-pod" | ||
|
|
||
| # Public URLs | ||
| BASEURL="dev.vendeuvre.lan" | ||
| BASE_URL="dev.vendeuvre.lan" | ||
| PUBLIC_BASE_URL="https://dev.vendeuvre.lan/llm-routing" | ||
|
|
||
| # Dev port assignments (+10 offset from production) | ||
| ROUTER_PORT="5010" | ||
| LITELLM_PORT="4010" | ||
| LANGFUSE_WEB_PORT="3011" | ||
| LANGFUSE_WORKER_PORT="3040" | ||
| POSTGRES_PORT="5442" | ||
| VALKEY_CACHE_PORT="6389" | ||
| VALKEY_LF_PORT="6390" | ||
| CLICKHOUSE_HTTP_PORT="8133" | ||
| CLICKHOUSE_TCP_PORT="9010" | ||
| CLICKHOUSE_INTERSERVER_PORT="9019" | ||
| MINIO_S3_PORT="9012" | ||
| MINIO_CONSOLE_PORT="9011" | ||
|
|
||
| # Dev uses locally-built router image (for testing code changes) | ||
| ROUTER_IMAGE="localhost/llm-routing-dev:latest" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the
.envfile contains spaces around the=sign (e.g.,KEY = value), the parsed key will retain a trailing space (e.g.,"KEY "). This prevents environment variables from being resolved correctly viaos.environ.get("KEY"). Stripping the key ensures robust parsing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed in the follow-up PR: added
key = key.strip()afterline.partition("=")in the .env parser. Keys with trailing spaces (e.g."KEY ") would previously fail to match inos.environ.get().