-
Notifications
You must be signed in to change notification settings - Fork 0
chore: address CodeRabbit and PR #27 review feedback #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0f8c84a
Configure gated Ollama routing and set llm-routing-ollama as free tie…
sheepdestroyer b3ae575
Address code review comments: Fix annotations race condition and hand…
sheepdestroyer 8338b23
Address new code reviews: Break Ollama fallback loop, use env key, an…
sheepdestroyer 528eb8d
fix: sanitize triage router 429 detail and force immediate LiteLLM co…
sheepdestroyer e14a543
docs: update fallback diagrams and cooldown behavior for Ollama models
sheepdestroyer 78f922d
fix: implement router-side Ollama cooldown to prevent crashloop
sheepdestroyer 214c637
chore: tidy up repository, remove hello world dummies, move and docum…
sheepdestroyer 12753bd
fix: resolve hardcoded worktree leaks and LiteLLM auth errors
sheepdestroyer bda8325
Address PR comments: robust httpx client teardown, dynamic path escap…
sheepdestroyer be67870
Implement Valkey global cooldown cache sync, standard HTTPX client li…
sheepdestroyer 38e080c
Address PR#11 code reviews: multimodal message extraction, concurrent…
sheepdestroyer dcccf7f
Address PR #12 code review comments
sheepdestroyer caef8f9
feat: expose model capabilities, token limits, and costs in Model Hub…
sheepdestroyer c34bd9e
chore: address review feedback on PR #14 (DRY purge helper, safety-ne…
sheepdestroyer 03b96f5
chore: address PR #15 code review fixes and fix CI workflow triggers
sheepdestroyer a7a5588
chore(deps): adjust dependabot root docker update time to 02:55 UTC (…
sheepdestroyer d22047a
chore: address code review feedback (YAML list indentation, raise_for…
sheepdestroyer 296b957
chore: trigger CI
sheepdestroyer 3466563
Address code reviews for PR #25
sheepdestroyer 43b1987
Address new PR reviews and CodeRabbit feedback
sheepdestroyer 07b035e
Address Gemini Code Assist review feedback on null text handling and …
sheepdestroyer eafa0fc
chore: address PR review feedback on DATABASE_URL, fallback password,…
sheepdestroyer 5424cda
chore: address CodeRabbit and PR #27 review feedback
sheepdestroyer 1619e25
chore: address Gemini Code Assist review feedback on PR #28
sheepdestroyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
DATABASE_URLpassword is set to***in the environment variables for thellm-triage-routercontainer. However, thepostgres-dbcontainer is configured with the passwordpostgres-local-pw-2026. Sincestart-stack.shdoes not replace***in the database URL, this will cause database connection and authentication failures on startup.