Skip to content

🧹 [code health improvement] Refactor try_agy_proxy to use AgyProxyRequest dataclass#378

Open
sheepdestroyer wants to merge 1 commit into
masterfrom
code-health-refactor-try-agy-proxy-12198992378528052019
Open

🧹 [code health improvement] Refactor try_agy_proxy to use AgyProxyRequest dataclass#378
sheepdestroyer wants to merge 1 commit into
masterfrom
code-health-refactor-try-agy-proxy-12198992378528052019

Conversation

@sheepdestroyer

@sheepdestroyer sheepdestroyer commented Jul 24, 2026

Copy link
Copy Markdown
Owner

🎯 What: Grouped parameters of try_agy_proxy into an AgyProxyRequest dataclass.
💡 Why: Reduces parameter sprawl and makes the function signature cleaner and easier to extend.
Verification: Verified by running the full test suite.
Result: Improved maintainability and readability.


PR created automatically by Jules for task 12198992378528052019 started by @sheepdestroyer

Summary by Sourcery

Refactor agy proxy request handling to use a dedicated dataclass and update callers and tests accordingly.

Enhancements:

  • Introduce AgyProxyRequest dataclass to encapsulate try_agy_proxy parameters and simplify the function signature.
  • Update chat_completions routing logic to construct and pass AgyProxyRequest instances when invoking try_agy_proxy.

Tests:

  • Adjust agy proxy circuit breaker integration test to import AgyProxyRequest and call try_agy_proxy with the new request object.

Summary by CodeRabbit

  • Refactor
    • Streamlined premium proxy request handling with a structured request format.
    • Preserved existing proxy behavior, including streaming and timeout options.
  • Bug Fixes
    • Improved compatibility when the premium proxy is blocked by circuit-breaker protection.
  • Tests
    • Updated verification coverage for the revised proxy request handling.

…class

Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-ai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Refactors try_agy_proxy to take a single AgyProxyRequest dataclass, updates internal usage to unpack the request, and adjusts call sites and tests to construct and pass the new request object.

Sequence diagram for constructing and using AgyProxyRequest in try_agy_proxy

sequenceDiagram
    participant RouterMain
    participant AgyProxyRequest
    participant AgyProxy

    RouterMain->>AgyProxyRequest: AgyProxyRequest(prompt, messages, session_id, total_timeout, stream, target_tier, client, cooldown_persistence)
    RouterMain->>AgyProxy: try_agy_proxy(request)
    AgyProxy->>AgyProxy: read request.prompt, request.messages, request.session_id
    AgyProxy->>RouterMain: agy_response Optional dict
Loading

File-Level Changes

Change Details Files
Introduce AgyProxyRequest dataclass and refactor try_agy_proxy to accept it instead of multiple parameters.
  • Add dataclasses import and define AgyProxyRequest with prompt, messages, session_id, total_timeout, stream, target_tier, client, and cooldown_persistence fields with defaults aligned to previous function signature.
  • Change try_agy_proxy signature to accept a single AgyProxyRequest instance and update docstring accordingly.
  • Unpack fields from the AgyProxyRequest at the beginning of try_agy_proxy to preserve existing internal logic and behavior.
router/agy_proxy.py
Update tests to construct and pass AgyProxyRequest into try_agy_proxy.
  • Modify imports to bring in AgyProxyRequest alongside try_agy_proxy.
  • Change asyncio.run invocation in the circuit breaker integration test to pass an AgyProxyRequest(prompt='test prompt') instead of a raw prompt string.
tests/test_a2_verify.py
Update router entrypoint to use AgyProxyRequest when calling try_agy_proxy.
  • Extend import in chat_completions handler to include AgyProxyRequest.
  • Replace direct try_agy_proxy(...) call with construction of an AgyProxyRequest using existing arguments and then call try_agy_proxy with that request object.
  • Ensure streaming flag and other parameters are passed into AgyProxyRequest to maintain current behavior.
router/main.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6abdfddc-56e8-47a8-9779-3d6d8f158fa8

📥 Commits

Reviewing files that changed from the base of the PR and between dcdd018 and 415cf2a.

📒 Files selected for processing (3)
  • router/agy_proxy.py
  • router/main.py
  • tests/test_a2_verify.py

📝 Walkthrough

Walkthrough

The AGY proxy now receives an AgyProxyRequest dataclass containing all proxy inputs. The chat completion route and verification test construct this request before calling try_agy_proxy.

Changes

AGY proxy request refactor

Layer / File(s) Summary
Request contract and proxy implementation
router/agy_proxy.py
Adds the AgyProxyRequest dataclass and changes try_agy_proxy to accept and unpack a single request object.
Caller and test migration
router/main.py, tests/test_a2_verify.py
Updates the production route and verification test to construct and pass AgyProxyRequest instances.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main refactor and matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch code-health-refactor-try-agy-proxy-12198992378528052019

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Inside try_agy_proxy, instead of unpacking every field from AgyProxyRequest into local variables, consider using request.<field> directly to reduce duplication and keep the code closer to the dataclass abstraction.
  • Consider marking AgyProxyRequest as keyword-only (e.g., @dataclass(kw_only=True)) to prevent accidental positional usage and keep call sites explicit and self-documenting as the dataclass evolves.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Inside `try_agy_proxy`, instead of unpacking every field from `AgyProxyRequest` into local variables, consider using `request.<field>` directly to reduce duplication and keep the code closer to the dataclass abstraction.
- Consider marking `AgyProxyRequest` as keyword-only (e.g., `@dataclass(kw_only=True)`) to prevent accidental positional usage and keep call sites explicit and self-documenting as the dataclass evolves.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant