🧪 [testing improvement] comprehensive tests for memory_mcp.py

[sheepdestroyer]

🎯 What: The testing gap in memory_mcp.py was addressed by adding comprehensive unit tests.
📊 Coverage: Covered happy paths, edge cases, error handling, and JSON-RPC method dispatch across handle_remember_memory, handle_retrieve_memories, handle_remove_specific_memory, and main_loop.
✨ Result: Test coverage for router/memory_mcp.py increased to 99%.

---

PR created automatically by Jules for task 9383090145333937560 started by @sheepdestroyer

Summary by Sourcery

Add comprehensive tests around memory_mcp JSON-RPC handling and memory management flows.

Tests:

• Extend unit coverage for memory listing, retrieval, creation, and deletion handlers, including filtering and HTTP error paths.
• Validate JSON-RPC request dispatching for initialization, tool listing, tool calls (success and error), and main loop behavior for valid, invalid, and notification messages.
• Add tests for logging behavior and parsing of memory values, including edge cases such as missing tags and None values.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[sourcery-ai]

Reviewer's Guide

This PR significantly expands and deepens unit test coverage for router/tests/test_memory_mcp.py, adding async tests that exercise HTTP interactions, filtering logic, JSON-RPC request handling, the stdin/stdout main loop, and logging behavior to reach ~99% coverage of memory_mcp.py.

File-Level Changes

Change	Details	Files
Add HTTP interaction tests for listing, remembering, and removing memories, including success and failure paths.	Introduce AsyncMock/MagicMock-based tests for _list_all_memories on 200 vs non-200 responses. Add success and error tests for handle_remember_memory using patched httpx.AsyncClient POST calls. Add tests for handle_remove_specific_memory and handle_remove_memory_category covering 200, 500, and httpx.HTTPError delete behavior.	router/tests/test_memory_mcp.py
Add tests that validate memory filtering and parsing logic for categories, global vs local scope, and malformed entries.	Add handle_retrieve_memories tests that verify correct filtering by category, is_global, and wildcard '*' category. Add filter-focused tests for handle_remove_memory_category and handle_remove_specific_memory that ensure scope/category mismatches skip items and invalid keys are ignored. Add _parse_memory_value tests for None input and JSON without tags field.	router/tests/test_memory_mcp.py
Add JSON-RPC dispatch and main loop tests to exercise initialize, tools/list, tools/call variants, error handling, and logging output.	Add handle_request tests for initialize, tools/list, tools/call for each tool, unknown tools, and handler exceptions producing isError responses. Add main_loop tests that simulate stdin JSON-RPC streams, covering valid requests, invalid JSON lines, notifications without id, empty lines, and unhandled exceptions. Add log() test that verifies formatted output to stderr via patched sys.stderr.	router/tests/test_memory_mcp.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Warning

Review limit reached

@sheepdestroyer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0ef3f4ec-c751-42c4-a817-a6762f6b58d3

📥 Commits

Reviewing files that changed from the base of the PR and between dcdd018 and f18390e.

📒 Files selected for processing (1)

• router/tests/test_memory_mcp.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test-memory-mcp-coverage-9383090145333937560

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}