motor.command() and CRLF

[owennewo]

This confused me - so I'm raising an issue for discussion.

motor.command(String) doesn't work well with Serial set to eol=CRLF (i.e. \r\n)

With CRLF all commands are 'sets' e.g. P will set the P term to zero.

A fix for this is to either configure your serial terminal to LF (\n)
e.g. platformio (which defaults to CRLF) you could set the following in you platformio.ini

monitor_flags =
  --eol
    LF

If we wanted to be more 'tolerant' we could change the code e.g. to be:

  char GET = user_command.charAt(1) == '\n' || user_command.charAt(1) == '\r';

[askuric]

https://community.simplefoc.com/t/node-oriented-communication-interface-for-the-simplefoc/466/14

[maxlem]

Just to mention that I just spent at least an hour trying to figure out with commander wasn't accepting my input
I'm using screen under linux, it's a very, very common way to interface with serial devices under linux.
so I went on and adde ddebug printouts until I found out that you were listening for a trailing \n.

ended up with this
int ch = serial.read(); received_chars[rec_cnt++] = (char)ch; // end of user input if (ch == '\n' || ch == '\r') [...]

I really think it should be patched asap, no matter what happens next with the commander interface?

Do you want a pull request?

[askuric]

You're right. If you have time go for it. :)

[askuric]

https://community.simplefoc.com/t/node-oriented-communication-interface-for-the-simplefoc/466/15

[maxlem]

see #75

Thank you!