fix(wait): resume live/draft async waits and preserve cell context on chained waits#4814
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview When an existing paused row is updated on re-pause, The workflow state API contract allows Reviewed by Cursor Bugbot for commit e39fa94. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR fixes two bugs in the async-wait/resume pipeline: it honors an explicit
Confidence Score: 5/5Safe to merge — both fixes are narrowly scoped, well-tested, and address confirmed runtime failures without altering unrelated code paths. The No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "fix(wait): resume live/draft async waits..." | Re-trigger Greptile |
|
@greptile review |
1 similar comment
|
@greptile review |
Summary
useDraftStatewhen building the execution context instead of deriving it fromisDeployedContext. Server-side draft runs (table dispatcher, HITL) no longer get forced onto the deployed branch on resume, fixing the "has no active deployment" error.paused_executions.metadatainpersistPauseResult's update branch so the stashedcellContextsurvives a re-pause. Chained async waits now write back to the table row after the second wait.Type of Change
Testing
Tested manually. Added unit tests (executor context useDraftState honoring/fallback, serializer preservation, persistPauseResult metadata merge). 194 tests pass across executor/execution, wait-handler, and execution-core suites.
bun run lintandbun run check:api-validation:strictpass.Checklist