feat(linq): audit fixes + native auto-registering webhook trigger by waleedlatif1 · Pull Request #5301 · simstudioai/sim

waleedlatif1 · 2026-06-30T23:33:07Z

Summary

Comprehensive audit of the Linq integration (34 tools + block) against the live Linq partner API and OpenAPI spec, with fixes:
- create_chat: read the sent message from the top-level response.message (was nested under chat, so always null)
- get_message/edit_message: expose canonical deliveryStatus; mark is_delivered/is_read deprecated
- send_message: fall back to from_handle.service/preferred_service for the service output
- list_phone_numbers: migrate deprecated health_status → reputation, add forwardingNumber, guard JSON parse
- check_imessage/check_rcs: guard response.json() parse
- mark_chat_read: document 1:1-only / group no-op behavior
New native webhook trigger with automatic subscription lifecycle:
- 6 triggers — message received / delivered / failed / read, reaction added, and all-events
- Standard Webhooks signature verification (HMAC-SHA256 over {id}.{timestamp}.{body}, whsec_ secret)
- createSubscription/deleteSubscription register and deregister the Linq webhook automatically on deploy/undeploy — no manual setup
- event_id-based idempotency; full 27-value WebhookEventType enum for the all-events trigger
Regenerated integration docs

Type of Change

Bug fix
New feature

Testing

Tested manually. Typecheck clean, biome clean, check:api-validation passes. Tools and trigger validated field-by-field against the live Linq OpenAPI spec; signature scheme and event enum verified verbatim.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Tools/block audit (validated against the live Linq partner API + OpenAPI spec): - create_chat: read the sent message from top-level response.message (was always null) - get_message/edit_message: expose canonical deliveryStatus; mark is_delivered/is_read deprecated - send_message: fall back to from_handle.service/preferred_service for service output - list_phone_numbers: migrate deprecated health_status to reputation; add forwardingNumber; guard JSON parse - check_imessage/check_rcs: guard response.json() parse - mark_chat_read: note 1:1-only / group no-op behavior Native webhook trigger (auto register + deregister): - 6 triggers (message received/delivered/failed/read, reaction added, all-events) - Standard Webhooks signature verification (HMAC-SHA256, whsec_ secret) - createSubscription/deleteSubscription manage the Linq subscription lifecycle - event_id idempotency; full 27-value WebhookEventType enum for all-events - regenerated docs

vercel · 2026-06-30T23:33:14Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 1, 2026 12:13am

cursor · 2026-06-30T23:33:17Z

PR Summary

Medium Risk
New inbound webhook path with signature verification and stored signing secrets is security-sensitive; subscription lifecycle also depends on user-supplied API keys. Tool output shape changes (deliveryStatus, phone number fields) may affect existing workflows that relied on older fields.

Overview
Adds six Linq workflow triggers (message received/delivered/failed/read, reaction added, and all-events) with block UI wiring, trigger registry entries, and integration metadata/docs.

Implements a Linq webhook provider that verifies Standard Webhooks signatures (HMAC-SHA256, clock skew), maps payloads to trigger inputs, deduplicates on event_id, filters by trigger-specific event_type, and auto-creates/deletes Linq webhook subscriptions on deploy/undeploy using the trigger API key and optional phone-number filters.

Linq tool outputs are aligned with the current API: canonical deliveryStatus on get/edit message (with deprecated isDelivered/isRead), expanded status enum on send, service fallbacks on send, forwardingNumber and reputation (with health_status fallback) on list phone numbers, safer response.json() handling on several tools, tighter RCS check docs (E.164 only), and clarified mark chat read behavior for 1:1 vs group chats.

^{Reviewed by Cursor Bugbot for commit 1f8c0ef. Configure here.}

greptile-apps · 2026-06-30T23:34:56Z

Greptile Summary

This PR updates the Linq integration with audited tool fixes and native webhook triggers. The main changes are:

Corrected Linq message, delivery status, and phone number output shapes.
Added six Linq webhook triggers with automatic subscription create and delete handling.
Added Standard Webhooks signature verification for Linq events.
Registered the new triggers in the Linq block, trigger registry, docs, and integration metadata.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
apps/sim/triggers/linq/utils.ts	Defines shared Linq trigger event mappings, setup text, outputs, and trigger-only configuration fields.
apps/sim/lib/webhooks/providers/linq.ts	Adds Linq webhook authentication, event matching, idempotency extraction, and subscription lifecycle handling.
apps/sim/tools/linq/list_phone_numbers.ts	Updates phone number response parsing and output metadata for reputation and forwarding number fields.
apps/sim/tools/linq/list_webhook_subscriptions.ts	Updates webhook subscription output metadata for nullable response fields.
apps/sim/blocks/blocks/linq.ts	Registers the new Linq triggers and their configuration fields on the Linq block.

_{Reviews (4): Last reviewed commit: "fix(linq): mark nullable list_webhook_su..." | Re-trigger Greptile}

…veryStatus enum doc Final validation against the raw Linq OpenAPI spec confirmed the sent message is at chat.message (CreateChatResult exposes only chat), so the data.message fallback was dead code. Also list all 7 DeliveryStatus values in the send_message output description.

…, nullable forwardingNumber Review + final pre-merge audit fixes: - Trigger apiKey/phoneNumbers subblocks collided with the block's tool apiKey state key — rename to triggerApiKey/triggerPhoneNumbers (per the namespacing rule from #2133) and read them in the webhook handler - edit_message: the API returns 204 No Content when editing an already-deleted message; guard the empty body instead of throwing on response.json() - list_phone_numbers: mark forwardingNumber output nullable (returns null) - check_rcs: tighten address hint (RCS is phone-only, not email) - regenerated docs

waleedlatif1 · 2026-06-30T23:54:51Z

@greptile

waleedlatif1 · 2026-06-30T23:54:52Z

@cursor review

deleteSubscription still read config.apiKey after the credential rename, so undeploy would skip the DELETE and orphan the Linq subscription. Match createSubscription's triggerApiKey key.

waleedlatif1 · 2026-07-01T00:06:48Z

@greptile

waleedlatif1 · 2026-07-01T00:06:49Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 8f8db29. Configure here.}

healthStatus returns null when Linq omits reputation/health_status; declare nullable: true to match the runtime value (same as forwardingNumber).

phoneNumbers/createdAt/updatedAt are null-coerced by mapWebhookSubscription; declare nullable: true on the array-item schema to match runtime (consistent with the top-level webhook outputs' optional flags).

waleedlatif1 · 2026-07-01T00:13:10Z

@greptile

waleedlatif1 · 2026-07-01T00:13:11Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 1f8c0ef. Configure here.}

greptile-apps Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread apps/sim/triggers/linq/utils.ts Outdated

Comment thread apps/sim/tools/linq/list_phone_numbers.ts

vercel Bot deployed to Preview June 30, 2026 23:37 View deployment

vercel Bot temporarily deployed to Preview June 30, 2026 23:38 Inactive

waleedlatif1 mentioned this pull request Jun 30, 2026

v0.7.18: landing, tools depth, media embeds in md editor, sonnet 5 #5296

Merged

cursor Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread apps/sim/lib/webhooks/providers/linq.ts Outdated

greptile-apps Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread apps/sim/lib/webhooks/providers/linq.ts Outdated

vercel Bot deployed to Preview June 30, 2026 23:59 View deployment

fix(linq): read triggerApiKey in webhook deleteSubscription

8f8db29

deleteSubscription still read config.apiKey after the credential rename, so undeploy would skip the DELETE and orphan the Linq subscription. Match createSubscription's triggerApiKey key.

vercel Bot temporarily deployed to Preview July 1, 2026 00:06 Inactive

cursor Bot reviewed Jul 1, 2026

View reviewed changes

greptile-apps Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread apps/sim/tools/linq/list_phone_numbers.ts

fix(linq): mark list_phone_numbers healthStatus output nullable

4a7fc21

healthStatus returns null when Linq omits reputation/health_status; declare nullable: true to match the runtime value (same as forwardingNumber).

vercel Bot temporarily deployed to Preview July 1, 2026 00:11 Inactive

fix(linq): mark nullable list_webhook_subscriptions item fields

1f8c0ef

phoneNumbers/createdAt/updatedAt are null-coerced by mapWebhookSubscription; declare nullable: true on the array-item schema to match runtime (consistent with the top-level webhook outputs' optional flags).

vercel Bot temporarily deployed to Preview July 1, 2026 00:13 Inactive

cursor Bot reviewed Jul 1, 2026

View reviewed changes

waleedlatif1 merged commit c1b84e4 into staging Jul 1, 2026
12 checks passed

waleedlatif1 deleted the worktree-linq-audit branch July 1, 2026 00:19

Uh oh!

Conversation

waleedlatif1 commented Jun 30, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jun 30, 2026

Uh oh!

waleedlatif1 commented Jun 30, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Jun 30, 2026 •

edited

Loading

cursor Bot commented Jun 30, 2026 •

edited

Loading

greptile-apps Bot commented Jun 30, 2026 •

edited

Loading