feat(careers): careers page backed by the Ashby job board#5316
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Roles are server-rendered for SEO; a client Footer Careers now points to Reviewed by Cursor Bugbot for commit 575d9f9. Configure here. |
Greptile SummaryThis PR adds an internal careers page backed by Ashby's job board. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (3): Last reviewed commit: "fix(careers): filter-aware empty state; ..." | Re-trigger Greptile |
|
@cursor review |
- validate jobUrl as http(s) only; drop postings with unsafe URLs - validate postings individually so one bad row can't empty the board - namespace the all-filter sentinel to avoid colliding with real values - dedupe the job metadata line (fixes duplicate React keys / Remote·Remote) - parse filters server-side so deep-linked views don't flash unfiltered
- JobGroups owns its empty copy via a filtersActive flag, so the server fallback and client board render identical, correct empty messaging (no-open-roles vs no-matching-filters) - convert remaining inline comments to TSDoc
4903dd3 to
575d9f9
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 575d9f9. Configure here.
Summary
/careerslanding page listing open roles pulled live from Sim's public Ashby job board (jobs.ashbyhq.com/sim), grouped by department with Team/Location filters.getAshbyJobs, mirrors the GitHub-stars pattern — cached, never throws) so every posting is in the crawlable HTML; the interactive board hydrates on top.?team=/?location=), shareable and deep-linkable; the roles list stays server-rendered via a<Suspense>fallback.max-w-[1446px]/px-12gutter,ChipSelectfilters,TrustedByreuse, single<h1>+ sr-only GEO summary)./careerspage; added/careersto the sitemap.Type of Change
Testing
Tested manually against the live Ashby board; typecheck and biome clean.
Checklist