improvement(settings): align design-system text-scale tokens across settings pages#5439
Conversation
… tokens Replace literal pixel text-size classes (text-[12px]/[13px]/[14px]/[16px]) with the named Tailwind scale tokens across inbox.tsx, inbox-enable-toggle, inbox-settings-tab, and inbox-task-list — pixel-identical, no visual change. Swap the hand-rolled toggle-row span pair for the emcn Label component, matching the toggle-row convention used elsewhere in settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Two-line list rows now consistently use Docs and audit: Reviewed by Cursor Bugbot for commit 0d398e1. Configure here. |
Greptile SummaryThis PR aligns settings-page typography with named design-system text tokens. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "improvement(settings): extend design-sys..." | Re-trigger Greptile |
…l settings pages Replace literal pixel text-size classes with named Tailwind scale tokens (text-caption/small/sm/base/md/lg) across every other settings page and shared component (member-list, api-keys, mcp, billing, credential-sets, workflow-mcp-servers, mothership, admin, byok, copilot, custom-tools, settings-resource-row, and the ee/ access-control, data-retention, whitelabeling, and shared setting-row components) — pixel-identical, no visual change. Document the row title/subtitle token pairing and toggle-row Label convention in sim-settings-pages.md and the add-settings-page skill's audit checklist so future pages default to it.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0d398e1. Configure here.
Summary
text-[11px]–text-[18px]) with the named Tailwind scale tokens (text-caption,text-small,text-sm,text-base,text-md,text-lg) — verified pixel-identical againsttailwind.config.ts's font-size scale, so nothing visually changesmember-list,api-keys,mcp,billing(+credit-usage-section,credit-usage-view),credential-sets,workflow-mcp-servers,mothership,admin,byok(key manager + provider-keys modal),copilot,custom-tools,settings-resource-row, and theee/access-control(+group-detail),data-retention,whitelabeling, and sharedsetting-rowcomponents<span>pairs for the emcnLabelcomponent (matches the toggle-row convention inadmin.tsx/general.tsx), wired with properhtmlFor/idpairingtext-sm+--text-bodyfor row title/value text andtext-caption+--text-mutedfor row subtitle/description text — the tokenized equivalent of the dominant pre-existing literal-pixel pairing used for this exact row shape (member-list.tsx'sROW_EMAIL_CLASSES/ROW_STATUS_CLASSESbeing the clearest precedent).claude/rules/sim-settings-pages.md(new "Text-scale tokens" section + audit checklist item) and theadd-settings-pageskill's Mode B audit steps, so new settings pages default to itType of Change
Testing
tsc --noEmitandbiome checkclean on every touched filetext-\[1[0-8]px\]undersettings/andee/) confirms zero literal pixel text sizes remaintailwind.config.ts) or a direct component substitution with matching default stylesChecklist