Skip to content

improvement(settings): align design-system text-scale tokens across settings pages#5439

Merged
waleedlatif1 merged 2 commits into
stagingfrom
feat/inbox-settings-design-system
Jul 6, 2026
Merged

improvement(settings): align design-system text-scale tokens across settings pages#5439
waleedlatif1 merged 2 commits into
stagingfrom
feat/inbox-settings-design-system

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace literal pixel text-size classes (text-[11px]text-[18px]) with the named Tailwind scale tokens (text-caption, text-small, text-sm, text-base, text-md, text-lg) — verified pixel-identical against tailwind.config.ts's font-size scale, so nothing visually changes
  • Started with the Inbox (Sim Mailer) settings page, then swept every other settings page and shared component with the same violation: member-list, api-keys, mcp, billing (+ credit-usage-section, credit-usage-view), credential-sets, workflow-mcp-servers, mothership, admin, byok (key manager + provider-keys modal), copilot, custom-tools, settings-resource-row, and the ee/ access-control (+ group-detail), data-retention, whitelabeling, and shared setting-row components
  • Swapped hand-rolled toggle-row <span> pairs for the emcn Label component (matches the toggle-row convention in admin.tsx/general.tsx), wired with proper htmlFor/id pairing
  • Standardized on text-sm + --text-body for row title/value text and text-caption + --text-muted for row subtitle/description text — the tokenized equivalent of the dominant pre-existing literal-pixel pairing used for this exact row shape (member-list.tsx's ROW_EMAIL_CLASSES/ROW_STATUS_CLASSES being the clearest precedent)
  • Documented the convention in .claude/rules/sim-settings-pages.md (new "Text-scale tokens" section + audit checklist item) and the add-settings-page skill's Mode B audit steps, so new settings pages default to it
  • No structural, handler, or behavior changes anywhere — entitlement gates keep their own chrome per existing convention

Type of Change

  • Improvement (styling/design-system alignment, no behavior change)

Testing

  • tsc --noEmit and biome check clean on every touched file
  • Full repo-wide grep (text-\[1[0-8]px\] under settings/ and ee/) confirms zero literal pixel text sizes remain
  • Diffed every change against the original — confirmed each swap is pixel-identical (verified sizes against tailwind.config.ts) or a direct component substitution with matching default styles

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

… tokens

Replace literal pixel text-size classes (text-[12px]/[13px]/[14px]/[16px])
with the named Tailwind scale tokens across inbox.tsx, inbox-enable-toggle,
inbox-settings-tab, and inbox-task-list — pixel-identical, no visual change.
Swap the hand-rolled toggle-row span pair for the emcn Label component,
matching the toggle-row convention used elsewhere in settings.
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jul 6, 2026 7:58pm

Request Review

@cursor

cursor Bot commented Jul 6, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Class-name and markup-only styling alignment across settings UI; no handlers, data flow, or business logic changes.

Overview
Replaces literal text-[Npx] classes across workspace settings and related ee/ UI with named Tailwind font-size tokens (text-caption, text-small, text-sm, text-xs, text-md, text-lg) so typography matches tailwind.config.ts without intended visual change.

Two-line list rows now consistently use text-sm + --text-body for the primary line and text-caption + --text-muted for subtitles (API keys, billing, MCP, inbox tasks, access control, data retention, shared settings-resource-row, etc.). Inbox enable swaps hand-rolled toggle labels for emcn Label with htmlFor/id on the Switch.

Docs and audit: .claude/rules/sim-settings-pages.md adds a "Text-scale tokens" section and a checklist item; add-settings-page skill adds a grep step and rules for pixel-only migrations.

Reviewed by Cursor Bugbot for commit 0d398e1. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR aligns settings-page typography with named design-system text tokens. The main changes are:

  • Literal pixel text-size classes replaced across settings and enterprise settings UI.
  • Toggle-row copy moved toward the shared Label and Switch pattern.
  • Settings-page guidance updated with the text-token convention and audit steps.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
.claude/rules/sim-settings-pages.md Adds settings-page guidance for named text-scale tokens and toggle-row label usage.
.claude/skills/add-settings-page/SKILL.md Adds audit steps for literal text-size cleanup and exact token replacements.
apps/sim/app/workspace/[workspaceId]/settings/components/inbox/components/inbox-settings-tab/inbox-settings-tab.tsx Replaces inbox settings row text-size literals with named text tokens.
apps/sim/app/workspace/[workspaceId]/settings/components/settings-resource-row/settings-resource-row.tsx Updates shared settings resource row typography to named text tokens.
apps/sim/ee/components/setting-row.tsx Updates enterprise setting row label and description typography to named text tokens.

Reviews (2): Last reviewed commit: "improvement(settings): extend design-sys..." | Re-trigger Greptile

…l settings pages

Replace literal pixel text-size classes with named Tailwind scale tokens
(text-caption/small/sm/base/md/lg) across every other settings page and
shared component (member-list, api-keys, mcp, billing, credential-sets,
workflow-mcp-servers, mothership, admin, byok, copilot, custom-tools,
settings-resource-row, and the ee/ access-control, data-retention,
whitelabeling, and shared setting-row components) — pixel-identical, no
visual change. Document the row title/subtitle token pairing and toggle-row
Label convention in sim-settings-pages.md and the add-settings-page skill's
audit checklist so future pages default to it.
@waleedlatif1 waleedlatif1 changed the title improvement(inbox): align Sim Mailer settings page with design-system tokens improvement(settings): align design-system text-scale tokens across settings pages Jul 6, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0d398e1. Configure here.

@waleedlatif1 waleedlatif1 merged commit 9538beb into staging Jul 6, 2026
14 checks passed
@waleedlatif1 waleedlatif1 deleted the feat/inbox-settings-design-system branch July 6, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant