-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat(bigquery): validate integration + add dataset/table lifecycle tools #5480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,116
−22
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ce3d33b
feat(bigquery): validate integration against live API docs, add datas…
waleedlatif1 6c44630
fix(bigquery): address Greptile + Cursor Bugbot review findings
waleedlatif1 e6c07dc
fix(bigquery): address second round of Cursor Bugbot findings
waleedlatif1 d6ba6be
fix(bigquery): final alignment pass from independent multi-agent vali…
waleedlatif1 6ca7101
fix(bigquery): stop leaking stale datasetId/tableId into create_datas…
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| import type { | ||
| GoogleBigQueryCreateDatasetParams, | ||
| GoogleBigQueryCreateDatasetResponse, | ||
| } from '@/tools/google_bigquery/types' | ||
| import type { ToolConfig } from '@/tools/types' | ||
|
|
||
| export const googleBigQueryCreateDatasetTool: ToolConfig< | ||
| GoogleBigQueryCreateDatasetParams, | ||
| GoogleBigQueryCreateDatasetResponse | ||
| > = { | ||
| id: 'google_bigquery_create_dataset', | ||
| name: 'BigQuery Create Dataset', | ||
| description: 'Create a new dataset in a Google BigQuery project', | ||
| version: '1.0.0', | ||
|
|
||
| oauth: { | ||
| required: true, | ||
| provider: 'google-bigquery', | ||
| }, | ||
|
|
||
| params: { | ||
| accessToken: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'hidden', | ||
| description: 'OAuth access token', | ||
| }, | ||
| projectId: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'user-or-llm', | ||
| description: 'Google Cloud project ID', | ||
| }, | ||
| datasetId: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'user-or-llm', | ||
| description: 'ID for the new BigQuery dataset', | ||
| }, | ||
| location: { | ||
| type: 'string', | ||
| required: false, | ||
| visibility: 'user-or-llm', | ||
| description: 'Geographic location for the dataset (e.g., "US", "EU")', | ||
| }, | ||
| friendlyName: { | ||
| type: 'string', | ||
| required: false, | ||
| visibility: 'user-or-llm', | ||
| description: 'Human-readable name for the dataset', | ||
| }, | ||
| description: { | ||
| type: 'string', | ||
| required: false, | ||
| visibility: 'user-or-llm', | ||
| description: 'Description of the dataset', | ||
| }, | ||
| }, | ||
|
|
||
| request: { | ||
| url: (params) => | ||
| `https://bigquery.googleapis.com/bigquery/v2/projects/${encodeURIComponent(params.projectId)}/datasets`, | ||
| method: 'POST', | ||
| headers: (params) => ({ | ||
| Authorization: `Bearer ${params.accessToken}`, | ||
| 'Content-Type': 'application/json', | ||
| }), | ||
| body: (params) => { | ||
| const body: Record<string, unknown> = { | ||
| datasetReference: { | ||
| projectId: params.projectId, | ||
| datasetId: params.datasetId.trim(), | ||
| }, | ||
| } | ||
| if (params.location) body.location = params.location | ||
| if (params.friendlyName) body.friendlyName = params.friendlyName | ||
| if (params.description) body.description = params.description | ||
| return body | ||
| }, | ||
| }, | ||
|
|
||
| transformResponse: async (response: Response) => { | ||
| const data = await response.json() | ||
| if (!response.ok) { | ||
| const errorMessage = data.error?.message || 'Failed to create BigQuery dataset' | ||
| throw new Error(errorMessage) | ||
| } | ||
|
|
||
| return { | ||
| success: true, | ||
| output: { | ||
| datasetId: data.datasetReference?.datasetId ?? null, | ||
| projectId: data.datasetReference?.projectId ?? null, | ||
| friendlyName: data.friendlyName ?? null, | ||
| description: data.description ?? null, | ||
| location: data.location ?? null, | ||
| creationTime: data.creationTime ?? null, | ||
| }, | ||
| } | ||
| }, | ||
|
|
||
| outputs: { | ||
| datasetId: { type: 'string', description: 'Unique dataset identifier' }, | ||
| projectId: { type: 'string', description: 'Project ID containing this dataset' }, | ||
| friendlyName: { | ||
| type: 'string', | ||
| description: 'Descriptive name for the dataset', | ||
| optional: true, | ||
| }, | ||
| description: { type: 'string', description: 'Dataset description', optional: true }, | ||
| location: { | ||
| type: 'string', | ||
| description: 'Geographic location where the data resides', | ||
| optional: true, | ||
| }, | ||
| creationTime: { | ||
| type: 'string', | ||
| description: 'Dataset creation time (milliseconds since epoch)', | ||
| optional: true, | ||
| }, | ||
| }, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,173 @@ | ||
| import type { | ||
| GoogleBigQueryCreateTableParams, | ||
| GoogleBigQueryCreateTableResponse, | ||
| } from '@/tools/google_bigquery/types' | ||
| import type { ToolConfig } from '@/tools/types' | ||
|
|
||
| export const googleBigQueryCreateTableTool: ToolConfig< | ||
| GoogleBigQueryCreateTableParams, | ||
| GoogleBigQueryCreateTableResponse | ||
| > = { | ||
| id: 'google_bigquery_create_table', | ||
| name: 'BigQuery Create Table', | ||
| description: 'Create a new table in a Google BigQuery dataset', | ||
| version: '1.0.0', | ||
|
|
||
| oauth: { | ||
| required: true, | ||
| provider: 'google-bigquery', | ||
| }, | ||
|
|
||
| params: { | ||
| accessToken: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'hidden', | ||
| description: 'OAuth access token', | ||
| }, | ||
| projectId: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'user-or-llm', | ||
| description: 'Google Cloud project ID', | ||
| }, | ||
| datasetId: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'user-or-llm', | ||
| description: 'BigQuery dataset ID', | ||
| }, | ||
| tableId: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'user-or-llm', | ||
| description: 'ID for the new BigQuery table', | ||
| }, | ||
| schema: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'user-or-llm', | ||
| description: | ||
| 'JSON array of column field definitions, e.g. [{"name":"id","type":"STRING","mode":"REQUIRED"}]', | ||
| }, | ||
| description: { | ||
| type: 'string', | ||
| required: false, | ||
| visibility: 'user-or-llm', | ||
| description: 'Description of the table', | ||
| }, | ||
| friendlyName: { | ||
| type: 'string', | ||
| required: false, | ||
| visibility: 'user-or-llm', | ||
| description: 'Human-readable name for the table', | ||
| }, | ||
| }, | ||
|
|
||
| request: { | ||
| url: (params) => | ||
| `https://bigquery.googleapis.com/bigquery/v2/projects/${encodeURIComponent(params.projectId)}/datasets/${encodeURIComponent(params.datasetId.trim())}/tables`, | ||
| method: 'POST', | ||
| headers: (params) => ({ | ||
| Authorization: `Bearer ${params.accessToken}`, | ||
| 'Content-Type': 'application/json', | ||
| }), | ||
| body: (params) => { | ||
| let fields: unknown | ||
| try { | ||
| fields = typeof params.schema === 'string' ? JSON.parse(params.schema) : params.schema | ||
| } catch { | ||
| fields = null | ||
| } | ||
| if ( | ||
| !Array.isArray(fields) || | ||
| fields.length === 0 || | ||
| !fields.every( | ||
| (f) => f && typeof f === 'object' && typeof (f as { name?: unknown }).name === 'string' | ||
| ) | ||
| ) { | ||
| throw new Error( | ||
| 'Schema must be a JSON array of column field definitions, e.g. [{"name":"id","type":"STRING"}]' | ||
| ) | ||
| } | ||
|
|
||
| const body: Record<string, unknown> = { | ||
| tableReference: { | ||
| projectId: params.projectId, | ||
| datasetId: params.datasetId.trim(), | ||
| tableId: params.tableId.trim(), | ||
| }, | ||
|
waleedlatif1 marked this conversation as resolved.
|
||
| schema: { fields }, | ||
| } | ||
|
waleedlatif1 marked this conversation as resolved.
|
||
| if (params.description) body.description = params.description | ||
| if (params.friendlyName) body.friendlyName = params.friendlyName | ||
| return body | ||
| }, | ||
| }, | ||
|
|
||
| transformResponse: async (response: Response) => { | ||
| const data = await response.json() | ||
| if (!response.ok) { | ||
| const errorMessage = data.error?.message || 'Failed to create BigQuery table' | ||
| throw new Error(errorMessage) | ||
| } | ||
|
|
||
| const schema = (data.schema?.fields ?? []).map( | ||
| (f: { name: string; type: string; mode?: string; description?: string }) => ({ | ||
| name: f.name, | ||
| type: f.type, | ||
| mode: f.mode ?? null, | ||
| description: f.description ?? null, | ||
| }) | ||
| ) | ||
|
|
||
| return { | ||
| success: true, | ||
| output: { | ||
| tableId: data.tableReference?.tableId ?? null, | ||
| datasetId: data.tableReference?.datasetId ?? null, | ||
| projectId: data.tableReference?.projectId ?? null, | ||
| type: data.type ?? null, | ||
| description: data.description ?? null, | ||
| schema, | ||
| creationTime: data.creationTime ?? null, | ||
| location: data.location ?? null, | ||
| }, | ||
| } | ||
| }, | ||
|
|
||
| outputs: { | ||
| tableId: { type: 'string', description: 'Table ID' }, | ||
| datasetId: { type: 'string', description: 'Dataset ID' }, | ||
| projectId: { type: 'string', description: 'Project ID' }, | ||
| type: { type: 'string', description: 'Table type (usually TABLE)', optional: true }, | ||
| description: { type: 'string', description: 'Table description', optional: true }, | ||
| schema: { | ||
| type: 'array', | ||
| description: 'Array of column definitions', | ||
| items: { | ||
| type: 'object', | ||
| properties: { | ||
| name: { type: 'string', description: 'Column name' }, | ||
| type: { type: 'string', description: 'Data type' }, | ||
| mode: { | ||
| type: 'string', | ||
| description: 'Column mode (NULLABLE, REQUIRED, or REPEATED)', | ||
| optional: true, | ||
| }, | ||
| description: { type: 'string', description: 'Column description', optional: true }, | ||
| }, | ||
| }, | ||
| }, | ||
| creationTime: { | ||
| type: 'string', | ||
| description: 'Table creation time (milliseconds since epoch)', | ||
| optional: true, | ||
| }, | ||
| location: { | ||
| type: 'string', | ||
| description: 'Geographic location where the table resides', | ||
| optional: true, | ||
| }, | ||
| }, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| import type { | ||
| GoogleBigQueryDeleteDatasetParams, | ||
| GoogleBigQueryDeleteDatasetResponse, | ||
| } from '@/tools/google_bigquery/types' | ||
| import type { ToolConfig } from '@/tools/types' | ||
|
|
||
| export const googleBigQueryDeleteDatasetTool: ToolConfig< | ||
| GoogleBigQueryDeleteDatasetParams, | ||
| GoogleBigQueryDeleteDatasetResponse | ||
| > = { | ||
| id: 'google_bigquery_delete_dataset', | ||
| name: 'BigQuery Delete Dataset', | ||
| description: 'Delete a dataset from a Google BigQuery project', | ||
| version: '1.0.0', | ||
|
|
||
| oauth: { | ||
| required: true, | ||
| provider: 'google-bigquery', | ||
| }, | ||
|
|
||
| params: { | ||
| accessToken: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'hidden', | ||
| description: 'OAuth access token', | ||
| }, | ||
| projectId: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'user-or-llm', | ||
| description: 'Google Cloud project ID', | ||
| }, | ||
| datasetId: { | ||
| type: 'string', | ||
| required: true, | ||
| visibility: 'user-or-llm', | ||
| description: 'BigQuery dataset ID to delete', | ||
| }, | ||
| deleteContents: { | ||
| type: 'boolean', | ||
| required: false, | ||
| visibility: 'user-or-llm', | ||
| description: 'Whether to delete tables inside the dataset (default: false)', | ||
| }, | ||
| }, | ||
|
|
||
| request: { | ||
| url: (params) => { | ||
| const url = new URL( | ||
| `https://bigquery.googleapis.com/bigquery/v2/projects/${encodeURIComponent(params.projectId)}/datasets/${encodeURIComponent(params.datasetId.trim())}` | ||
| ) | ||
| if (params.deleteContents !== undefined) { | ||
| url.searchParams.set('deleteContents', String(params.deleteContents)) | ||
| } | ||
| return url.toString() | ||
| }, | ||
| method: 'DELETE', | ||
| headers: (params) => ({ | ||
| Authorization: `Bearer ${params.accessToken}`, | ||
| }), | ||
| }, | ||
|
|
||
| transformResponse: async (response: Response) => { | ||
| if (!response.ok) { | ||
| const data = await response.json() | ||
| const errorMessage = data.error?.message || 'Failed to delete BigQuery dataset' | ||
| throw new Error(errorMessage) | ||
| } | ||
|
|
||
| return { | ||
| success: true, | ||
| output: { | ||
| deleted: true, | ||
| }, | ||
| } | ||
| }, | ||
|
|
||
| outputs: { | ||
| deleted: { type: 'boolean', description: 'Whether the dataset was deleted' }, | ||
| }, | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.