Skip to content

fix(landing): contain sr-only logos heading to stop phantom root scrollbar #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Jul 11, 2026
Merged

fix(landing): contain sr-only logos heading to stop phantom root scrollbar #5585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...p/(landing)/components/platform-page/components/platform-logos-row/platform-logos-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,16 @@ import { Logos } from '@/app/(landing)/components/logos'
*
* Wrapped as a labelled `<section>` so it is a discrete, crawlable landmark; the
* heading is sr-only because the logos are a proof band rather than a content
* section, but the H2 keeps the page's heading hierarchy intact.
* section, but the H2 keeps the page's heading hierarchy intact. The section is
* `relative` so the `sr-only` (`position: absolute`) heading is contained by it
* rather than falling back to the document root - matching {@link Features}'s
* `relative` wrapper for its own `sr-only` heading, and avoiding a phantom root
* scrollbar (the heading's un-offset static position would otherwise inflate
* `document.documentElement`'s scroll height by its own position in the page).
*/
export function PlatformLogosRow() {
return (
<section id='platform-logos' aria-labelledby='platform-logos-heading'>
<section id='platform-logos' aria-labelledby='platform-logos-heading' className='relative'>
<h2 id='platform-logos-heading' className='sr-only'>
Companies building AI agents with Sim
</h2>
Expand Down
9 changes: 7 additions & 2 deletions ...landing)/components/solutions-page/components/solutions-logos-row/solutions-logos-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,16 @@ import { Logos } from '@/app/(landing)/components/logos'
*
* Wrapped as a labelled `<section>` so it is a discrete, crawlable landmark; the
* heading is sr-only because the logos are a proof band rather than a content
* section, but the H2 keeps the page's heading hierarchy intact.
* section, but the H2 keeps the page's heading hierarchy intact. The section is
* `relative` so the `sr-only` (`position: absolute`) heading is contained by it
* rather than falling back to the document root - matching {@link Features}'s
* `relative` wrapper for its own `sr-only` heading, and avoiding a phantom root
* scrollbar (the heading's un-offset static position would otherwise inflate
* `document.documentElement`'s scroll height by its own position in the page).
*/
export function SolutionsLogosRow() {
return (
<section id='solutions-logos' aria-labelledby='solutions-logos-heading'>
<section id='solutions-logos' aria-labelledby='solutions-logos-heading' className='relative'>
<h2 id='solutions-logos-heading' className='sr-only'>
Companies building AI agents with Sim
</h2>
Expand Down
Loading