perf(search): cap Cmd-K result groups so typing isn't blocked by reshuffle by waleedlatif1 · Pull Request #5597 · simstudioai/sim

waleedlatif1 · 2026-07-11T17:56:57Z

Summary

Two closely-related fixes to the Cmd-K command palette search:

1. Input latency (perf). Typing stalled and dropped the next character while results reshuffle, because every result group re-rendered its full match set each keystroke — the catalog alone is 1,000+ tool operations, plus every workflow/file in large workspaces. Added a per-group cap (filterAndCap, MAX_RESULTS_PER_GROUP = 50) applied only while searching. Results are score-sorted, so the cap trims just the low-relevance tail; the empty/browse state is returned in full (no browsable item is hidden).

2. Exact name matches now win (ranking). Blocks/tools were ranked against their full searchValue (name + type + every command-searchable option label), so an exact name match couldn't earn the exact-match bonus and paid a length penalty inflated by option text — e.g. Agent lost to Pi Coding Agent for the query "agent". Now ranked by name first, falling back to searchValue only when the name doesn't match (via a new optional secondary accessor on filterAndSort/filterAndCap), so an exact name match always wins while a block stays findable by an option label.

Minimal and self-contained: no UX/layout changes, no new components; single-field ranking (workflows, files, etc.) is byte-identical.

Type of Change

Bug fix (performance + ranking)

Testing

Unit tests for filterAndCap (caps active search, never caps the browse state, preserves ranking) and name-first ranking (exact name beats a substring buried in another item's option text; still findable by option label). utils.test.ts passes (24 tests).
Typecheck + lint clean.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…uffle Every result group re-rendered its full match set on each keystroke — the catalog alone is 1,000+ tool operations, plus all workflows/files in large workspaces — so the deferred re-render that reshuffles results stalls the input and drops the next character. Add a per-group cap (filterAndCap, MAX_RESULTS_PER_GROUP=50) applied to every variable-size group. Results are already score-sorted, so the cap only trims the low-relevance tail while keeping the DOM and per-keystroke reconciliation bounded. No UX changes.

vercel · 2026-07-11T17:57:03Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 11, 2026 6:45pm

cursor · 2026-07-11T17:57:07Z

PR Summary

Low Risk
Search-modal filtering and ranking only; no auth, data, or API changes. Main tradeoff is matches ranked below the top 50 per group may be hidden while typing.

Overview
Fixes Cmd-K typing lag and block/tool ranking by changing how search results are filtered and capped.

While the user is searching, each result group now uses filterAndCap (50 rows max, score-sorted) instead of rendering every match on every keystroke; empty or whitespace-only input still returns the full browse list unchanged. filterAndSort trims queries, and blocks/tools rank on name first with searchValue as a secondary field so an exact Agent name beats Pi Coding Agent when the query is agent, while option labels like gpt-4o still surface items. Catalog integrations only show when deferredSearch.trim() is non-empty.

Unit tests cover name-first ordering and cap behavior (active search capped, browse uncapped, whitespace treated as browse).

^{Reviewed by Cursor Bugbot for commit 54a0129. Configure here.}

greptile-apps · 2026-07-11T17:58:37Z

Greptile Summary

This PR improves Cmd-K search performance and ranking. The main changes are:

Caps each result group while an active search is running.
Keeps empty and whitespace-only browse states uncapped.
Ranks block and tool names before secondary search text.
Hides catalog integrations until the user enters a meaningful query.
Adds tests for capping, whitespace handling, and name-first ranking.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx	Updates command palette groups to use capped search results and applies trimmed query checks for catalog integrations.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/utils.ts	Adds capped filtering, trims search input for browse mode, and supports name-first ranking with secondary fallback text.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/utils.test.ts	Adds tests for capped active search, uncapped browse states, whitespace input, and secondary search ranking.

_{Reviews (5): Last reviewed commit: "fix(search): keep integrations catalog h..." | Re-trigger Greptile}

…e list Keep the empty state byte-for-byte identical to before — capping applies only to the top-ranked matches of an active query (the reshuffling per-keystroke render that stalls input), never to the full browsable list. No browsable result a user could otherwise see is hidden.

waleedlatif1 · 2026-07-11T18:07:20Z

@greptile

waleedlatif1 · 2026-07-11T18:07:21Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 3107b1b. Configure here.}

Blocks and tools were ranked against their full searchValue (name + type + every command-searchable option label), so an exact name match couldn't earn the exact-match bonus and paid a length penalty inflated by option text — e.g. "Agent" lost to "Pi Coding Agent" for the query "agent". Rank by name first via a new optional secondary accessor on filterAndSort/filterAndCap, falling back to searchValue only when the name doesn't match, so an exact name match always wins while a block stays findable by an option label.

waleedlatif1 · 2026-07-11T18:27:05Z

@greptile

waleedlatif1 · 2026-07-11T18:27:07Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit ee6df29. Configure here.}

A whitespace-only query (e.g. a single space) was truthy, so it both filtered (a space matches the spaces in multi-word labels) and capped large groups to 50 while the palette looked empty. Trim the query at the source in filterAndSort so every caller treats whitespace-only as browse, and decide the cap on the trimmed query — whitespace-only input now returns the full, unfiltered browse state.

waleedlatif1 · 2026-07-11T18:39:13Z

@greptile

waleedlatif1 · 2026-07-11T18:39:14Z

@cursor review

The filteredIntegrations guard used the raw deferredSearch, so a whitespace-only value passed it while filterAndCap trimmed the same value to browse and returned the full catalog. Guard on deferredSearch.trim() to match the trimmed-emptiness semantics — the catalog stays hidden until the user types something meaningful.

waleedlatif1 · 2026-07-11T18:50:19Z

@greptile

waleedlatif1 · 2026-07-11T18:50:20Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 54a0129. Configure here.}

greptile-apps Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/utils.ts Outdated

vercel Bot temporarily deployed to Preview July 11, 2026 18:02 Inactive

cursor Bot reviewed Jul 11, 2026

View reviewed changes

greptile-apps Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/utils.ts Outdated

vercel Bot temporarily deployed to Preview July 11, 2026 18:22 Inactive

cursor Bot reviewed Jul 11, 2026

View reviewed changes

greptile-apps Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/utils.ts

vercel Bot temporarily deployed to Preview July 11, 2026 18:34 Inactive

cursor Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread ...im/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx

greptile-apps Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread ...im/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx

vercel Bot temporarily deployed to Preview July 11, 2026 18:45 Inactive

cursor Bot reviewed Jul 11, 2026

View reviewed changes

waleedlatif1 merged commit 67a2f00 into staging Jul 11, 2026
18 checks passed

waleedlatif1 deleted the perf/cmdk-input-latency branch July 11, 2026 21:16

waleedlatif1 mentioned this pull request Jul 12, 2026

v0.7.30: md editor improvements, og image updates, spacexai hosted keys, cmd-k speedups, pagespeed optimizations, security hardening #5611

Merged

Uh oh!

Conversation

waleedlatif1 commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

waleedlatif1 commented Jul 11, 2026

Uh oh!

waleedlatif1 commented Jul 11, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Jul 11, 2026

Uh oh!

waleedlatif1 commented Jul 11, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Jul 11, 2026

Uh oh!

waleedlatif1 commented Jul 11, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 11, 2026

Uh oh!

waleedlatif1 commented Jul 11, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Jul 11, 2026 •

edited

Loading

vercel Bot commented Jul 11, 2026 •

edited

Loading

cursor Bot commented Jul 11, 2026 •

edited

Loading

greptile-apps Bot commented Jul 11, 2026 •

edited

Loading