Skip to content

fix: broken python 3.10 unit test#1509

Merged
WilliamBergamin merged 1 commit into
mainfrom
imporve-ci
May 27, 2026
Merged

fix: broken python 3.10 unit test#1509
WilliamBergamin merged 1 commit into
mainfrom
imporve-ci

Conversation

@WilliamBergamin
Copy link
Copy Markdown
Contributor

Summary

This PR aims to fix broken python 3.10 broken continuous integration pipeline that was relying on deprecated features of falcon

Testing

Continuous integration tests should be sufficient

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@WilliamBergamin WilliamBergamin added this to the 1.29.0 milestone May 27, 2026
@WilliamBergamin WilliamBergamin requested a review from vegeris May 27, 2026 16:15
@WilliamBergamin WilliamBergamin self-assigned this May 27, 2026
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner May 27, 2026 16:15
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.30%. Comparing base (bddebca) to head (1121c97).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1509   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files         228      228           
  Lines        7271     7271           
=======================================
  Hits         6639     6639           
  Misses        632      632           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown

@vegeris vegeris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@WilliamBergamin WilliamBergamin merged commit 87d0897 into main May 27, 2026
16 checks passed
@WilliamBergamin WilliamBergamin deleted the imporve-ci branch May 27, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants