fix: align WSGI/ASGI test infrastructure and handler with spec#1513
Open
WilliamBergamin wants to merge 8 commits into
Open
fix: align WSGI/ASGI test infrastructure and handler with spec#1513WilliamBergamin wants to merge 8 commits into
WilliamBergamin wants to merge 8 commits into
Conversation
Updates the requirements on [tornado](https://github.com/tornadoweb/tornado) to permit the latest version. - [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst) - [Commits](tornadoweb/tornado@v6.0.0...v6.5.6) --- updated-dependencies: - dependency-name: tornado dependency-version: 6.5.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
- Coverage 91.30% 91.28% -0.03%
==========================================
Files 228 228
Lines 7271 7275 +4
==========================================
+ Hits 6639 6641 +2
- Misses 632 634 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use stdlib wsgiref.validate and asgiref.testing to ensure test servers are fully PEP 3333 / ASGI spec-compliant.
This also removes dependencies we were not using, and audit the implementation of the WSGI and ASGI adapters
Testing
Continuous integration pipeline should be sufficient
If you want to test it out locally
# requirements.txt pytest==9.0.3 ruff==0.15.12 uvicorn[standard] aiohttp path/to/bolt-python/dist/slack_bolt-1.28.0-py2.py3-none-any.whl slack-cli-hooks<1.0.0{ "_metadata": { "major_version": 1, "minor_version": 1 }, "display_information": { "name": "test-asgi-adapter" }, "features": { "app_home": { "home_tab_enabled": true, "messages_tab_enabled": false, "messages_tab_read_only_enabled": true }, "bot_user": { "display_name": "test-asgi-adapter", "always_online": false } }, "oauth_config": { "scopes": { "bot": [ "chat:write" ] } }, "settings": { "event_subscriptions": { "bot_events": [ "app_home_opened" ] }, "interactivity": { "is_enabled": false }, "org_deploy_enabled": true, "socket_mode_enabled": false, "token_rotation_enabled": false } }Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.