fix(socket-mode): suppress heartbeat warning during shutdown - #2697
Open
Grmiade wants to merge 1 commit into
Open
fix(socket-mode): suppress heartbeat warning during shutdown#2697Grmiade wants to merge 1 commit into
Grmiade wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 2253dff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Socket Mode application shuts down, the client sends a WebSocket close frame but leaves its heartbeat interval active until the peer completes the close handshake. If Slack does not send a pong in the 5-second heartbeat window, the SDK logs
A pong wasn't received from the server before the timeout of 5000ms!even though the disconnect was intentional.Solution
Stop heartbeat monitoring immediately for explicit
SocketModeClient.disconnect()calls, while preserving heartbeat detection for unexpected connection failures. The close handshake and disconnected lifecycle event remain unchanged.Validation
npm run test:unit --workspace @slack/socket-modenpx @biomejs/biome check packages/socket-mode/src/SocketModeClient.ts packages/socket-mode/src/SlackWebSocket.ts packages/socket-mode/src/SlackWebSocket.test.ts