Skip to content

Fix #701 by reverting the change for simultaneous request handling - #702

Merged
seratch merged 2 commits into
slackapi:masterfrom
seratch:issue-701
May 25, 2020
Merged

Fix #701 by reverting the change for simultaneous request handling#702
seratch merged 2 commits into
slackapi:masterfrom
seratch:issue-701

Conversation

@seratch

@seratch seratch commented May 25, 2020

Copy link
Copy Markdown
Contributor

Summary

This pull request reverts #667 as the change in the PR caused another issue reported at #701 . I will be reopening #558 #619 and those issues may be resolved by another approach in the future.

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented area:concurrency Issues and PRs related to concurrency rtm-client labels May 25, 2020
@seratch seratch added this to the 2.6.1 milestone May 25, 2020
@codecov

codecov Bot commented May 25, 2020

Copy link
Copy Markdown

Codecov Report

Merging #702 into master will increase coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   85.55%   85.66%   +0.10%     
==========================================
  Files          19       19              
  Lines        2638     2630       -8     
  Branches      253      251       -2     
==========================================
- Hits         2257     2253       -4     
+ Misses        286      282       -4     
  Partials       95       95              
Impacted Files Coverage Δ
slack/rtm/client.py 84.65% <50.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439c7ae...10563ef. Read the comment docs.

@seratch
seratch merged commit e7df0db into slackapi:master May 25, 2020
@seratch
seratch deleted the issue-701 branch May 25, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:concurrency Issues and PRs related to concurrency bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented rtm-client Version: 2x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant